From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: [ofa-general] Re: [PATCH 2/9] mlx4_en: Removed TX locking when polling TX cq Date: Thu, 25 Dec 2008 18:16:16 -0800 (PST) Message-ID: <20081225.181616.195227579.davem@davemloft.net> References: <494F6536.6040107@mellanox.co.il> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, rdreier@cisco.com, general@lists.openfabrics.org, jeff@garzik.org To: yevgenyp@mellanox.co.il Return-path: In-Reply-To: <494F6536.6040107@mellanox.co.il> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: general-bounces@lists.openfabrics.org Errors-To: general-bounces@lists.openfabrics.org List-Id: netdev.vger.kernel.org From: Yevgeny Petrilin Date: Mon, 22 Dec 2008 12:00:22 +0200 > There is no need to synchronize the polling with the transmit > function. The only place to synchronize is when we process > the cq from the transmit function. Also removed spin_lock_irq, > and using spin_trylock, if somebody else is already processing the cq, > no need to wait for it to finish. > > Signed-off-by: Yevgeny Petrilin Applied.