From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 22/27] drivers/net/wan/z85230.c: fix sparse warnings: un-EXPORT symbols Date: Fri, 26 Dec 2008 00:12:14 -0800 (PST) Message-ID: <20081226.001214.02292973.davem@davemloft.net> References: <20081222191259.11807.53190.stgit@vmbox.hanneseder.net> <20081222191813.11807.144.stgit@vmbox.hanneseder.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: hannes@hanneseder.net Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:53373 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750752AbYLZIMM (ORCPT ); Fri, 26 Dec 2008 03:12:12 -0500 In-Reply-To: <20081222191813.11807.144.stgit@vmbox.hanneseder.net> Sender: netdev-owner@vger.kernel.org List-ID: From: Hannes Eder Date: Mon, 22 Dec 2008 20:18:13 +0100 > The symbols are only references within the translation unit they are > defined in, so un-EXPORT them und make them 'static'. > > Fix this sparse warnings: > > drivers/net/wan/z85230.c:604:25: warning: symbol 'z8530_dma_sync' was not declared. Should it be static? > drivers/net/wan/z85230.c:613:25: warning: symbol 'z8530_txdma_sync' was not declared. Should it be static? > > Signed-off-by: Hannes Eder Applied.