From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, jeff@garzik.org, peter.p.waskiewicz.jr@intel.com
Subject: Re: [NET-NEXT PATCH 3/3] ixgbe: Fix set_ringparam in ixgbe to use the same memory pools.
Date: Fri, 26 Dec 2008 01:36:41 -0800 (PST) [thread overview]
Message-ID: <20081226.013641.144674900.davem@davemloft.net> (raw)
In-Reply-To: <20081225090241.13754.31673.stgit@lost.foo-projects.org>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 25 Dec 2008 01:02:41 -0800
> The adapter rings are kcalloc()'d, but in set_ringparam() in ixgbe_ethtool,
> we replace that memory from the vmalloc() pool. This can result in a NULL
> pointer reference when trying to modify the rings at a later time, or on
> device removal.
>
> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
next prev parent reply other threads:[~2008-12-26 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-25 9:02 [NET-NEXT PATCH 1/3] net: Init NAPI dev_list on napi_del Jeff Kirsher
2008-12-25 9:02 ` [NET-NEXT PATCH 2/3] ixgbe: Fix NAPI enable/disable path when using DCB Jeff Kirsher
2008-12-26 9:36 ` David Miller
2008-12-25 9:02 ` [NET-NEXT PATCH 3/3] ixgbe: Fix set_ringparam in ixgbe to use the same memory pools Jeff Kirsher
2008-12-26 9:36 ` David Miller [this message]
2008-12-26 9:35 ` [NET-NEXT PATCH 1/3] net: Init NAPI dev_list on napi_del David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081226.013641.144674900.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).