From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: gro: Fix potential use after free
Date: Fri, 26 Dec 2008 14:57:59 -0800 (PST) [thread overview]
Message-ID: <20081226.145759.148181271.davem@davemloft.net> (raw)
In-Reply-To: <20081226224401.GA22329@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 27 Dec 2008 09:44:01 +1100
> gro: Fix potential use after free
>
> The initial skb may have been freed after napi_gro_complete in
> napi_gro_receive if it was merged into an existing packet. Thus
> we cannot check same_flow (which indicates whether it was merged)
> after calling napi_gro_complete.
>
> This patch fixes this by saving the same_flow status before the
> call to napi_gro_complete.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks Herbert.
prev parent reply other threads:[~2008-12-26 22:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-26 22:44 gro: Fix potential use after free Herbert Xu
2008-12-26 22:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081226.145759.148181271.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox