netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Allow dependancies of FDDI & Tokenring to be modular.
@ 2008-12-26 21:52 Dave Jones
  2008-12-28  4:44 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2008-12-26 21:52 UTC (permalink / raw)
  To: netdev

I noticed it isn't possible to build token ring & fddi drivers
without causing LLC, and a bunch of other things to be forced
built-in.  For distro kernels, this means carrying a chunk of
code in the vmlinuz, even if the user doesn't use those protocols.

Signed-off-by: Dave Jones <davej@redhat.com>

-- 
I don't have any hardware for either of these, so I'm unable to test
if it actually works or not, but seeing as the bits in net/ all have
module_init's, it seems they were meant to be allowed to be built this way.

--- linux-2.6.28.noarch/drivers/net/Kconfig~	2008-12-25 23:28:55.000000000 -0500
+++ linux-2.6.28.noarch/drivers/net/Kconfig	2008-12-25 23:29:09.000000000 -0500
@@ -2637,7 +2637,7 @@ config RIONET_RX_SIZE
 	default "128"
 
 config FDDI
-	bool "FDDI driver support"
+	tristate "FDDI driver support"
 	depends on (PCI || EISA || TC)
 	help
 	  Fiber Distributed Data Interface is a high speed local area network
--- linux-2.6.28.noarch/drivers/net/tokenring/Kconfig~	2008-12-25 23:54:29.000000000 -0500
+++ linux-2.6.28.noarch/drivers/net/tokenring/Kconfig	2008-12-25 23:54:34.000000000 -0500
@@ -4,7 +4,7 @@
 
 # So far, we only have PCI, ISA, and MCA token ring devices
 menuconfig TR
-	bool "Token Ring driver support"
+	tristate "Token Ring driver support"
 	depends on NETDEVICES && !UML
 	depends on (PCI || ISA || MCA || CCW)
 	select LLC

-- 
http://www.codemonkey.org.uk

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Allow dependancies of FDDI & Tokenring to be modular.
  2008-12-26 21:52 [PATCH] Allow dependancies of FDDI & Tokenring to be modular Dave Jones
@ 2008-12-28  4:44 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-12-28  4:44 UTC (permalink / raw)
  To: davej; +Cc: netdev

From: Dave Jones <davej@redhat.com>
Date: Fri, 26 Dec 2008 16:52:51 -0500

> I noticed it isn't possible to build token ring & fddi drivers
> without causing LLC, and a bunch of other things to be forced
> built-in.  For distro kernels, this means carrying a chunk of
> code in the vmlinuz, even if the user doesn't use those protocols.
> 
> Signed-off-by: Dave Jones <davej@redhat.com>

Looks good.

Applied, thanks Dave.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-12-28  4:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-26 21:52 [PATCH] Allow dependancies of FDDI & Tokenring to be modular Dave Jones
2008-12-28  4:44 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).