netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: lizf@cn.fujitsu.com
Cc: netdev@vger.kernel.org
Subject: Re: cls_cgroup: clean up for cgroup part
Date: Mon, 29 Dec 2008 19:38:36 -0800 (PST)	[thread overview]
Message-ID: <20081229.193836.123306072.davem@davemloft.net> (raw)
In-Reply-To: <20081229.190724.20711084.davem@davemloft.net>


Actually, the tree doesn't even build after applying this
patch.

How did you test this?

net/sched/cls_cgroup.c: In function ‘write_classid’:
net/sched/cls_cgroup.c:68: error: implicit declaration of function ‘net_cls_state’
net/sched/cls_cgroup.c:68: error: invalid type argument of ‘->’

I made the obvious fixup to this change, but...

Come on, build test your changes. :-(




  reply	other threads:[~2008-12-30  3:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-30  3:07 cls_cgroup: clean up for cgroup part David Miller
2008-12-30  3:38 ` David Miller [this message]
2008-12-30  3:43   ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081229.193836.123306072.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=lizf@cn.fujitsu.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).