netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: [UNTESTED] gro: Add page frag support
Date: Mon, 29 Dec 2008 23:07:03 -0800 (PST)	[thread overview]
Message-ID: <20081229.230703.265458431.davem@davemloft.net> (raw)
In-Reply-To: <20081229122445.GA11161@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 29 Dec 2008 23:24:46 +1100

> On Sat, Dec 27, 2008 at 09:51:57AM +1100, Herbert Xu wrote:
> > 
> > This patch is totally untested so please don't apply it.  I need
> > to hack the e1000e driver to not make skbs before I can test it.
> 
> OK I've tested it with a hacked e1000e driver, which indeed revealed
> a gaping hole in my design :) The pages interface needs to have some
> extra fields for the checksum information.
> 
> Here's a patch that actually works.
> 
>     gro: Use gso_size to store MSS
>     
>     In order to allow GRO packets without frag_list at all, we need to
>     store the MSS in the packet itself.  The obvious place is gso_size.
>     The only thing to watch out for is if the packet ends up not being
>     GRO then we need to clear gso_size before pushing the packet into
>     the stack.
 ...
> And the real thing.

This work looks great to me Herbert.

When you want me to apply this stuff, send them as two
seperate changes with updated commit messages.

Thanks a lot!

  reply	other threads:[~2008-12-30  7:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-26 22:51 [UNTESTED] gro: Add page frag support Herbert Xu
2008-12-26 23:13 ` Herbert Xu
2008-12-29 12:24 ` Herbert Xu
2008-12-30  7:07   ` David Miller [this message]
2008-12-30 10:07     ` [1/2] gro: Use gso_size to store MSS Herbert Xu
2008-12-30 10:08       ` [2/2] gro: Add page frag support Herbert Xu
2009-01-02  4:20         ` Herbert Xu
2009-01-05  0:13           ` David Miller
2009-01-05  0:13       ` [1/2] gro: Use gso_size to store MSS David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081229.230703.265458431.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).