netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* 2.6.28-git1 gianfar compile failure (ppc).
@ 2008-12-29  5:41 Dave Jones
  2009-01-09 18:10 ` Andy Fleming
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2008-12-29  5:41 UTC (permalink / raw)
  To: Dai Haruki, Andy Fleming; +Cc: netdev

ERROR: "cacheable_memzero" [drivers/net/gianfar_driver.ko] undefined!

Introduced in a22823e72a4821ce1d4a248fbd8f5a81795af339

I guess that needs exporting for when gianfar is modular, but I've no
idea how to export things from powerpc assembly.

	Dave

-- 
http://www.codemonkey.org.uk

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: 2.6.28-git1 gianfar compile failure (ppc).
  2008-12-29  5:41 2.6.28-git1 gianfar compile failure (ppc) Dave Jones
@ 2009-01-09 18:10 ` Andy Fleming
  0 siblings, 0 replies; 2+ messages in thread
From: Andy Fleming @ 2009-01-09 18:10 UTC (permalink / raw)
  To: Dave Jones; +Cc: Dai Haruki, Andy Fleming, netdev

On Sun, Dec 28, 2008 at 11:41 PM, Dave Jones <davej@redhat.com> wrote:
> ERROR: "cacheable_memzero" [drivers/net/gianfar_driver.ko] undefined!
>
> Introduced in a22823e72a4821ce1d4a248fbd8f5a81795af339
>
> I guess that needs exporting for when gianfar is modular, but I've no
> idea how to export things from powerpc assembly.
>
>        Dave
>


This patch which was posted to linuxppc-dev should fix your bug:

From: Kumar Gala <galak@kernel.crashing.org>
Date: Tue, Jan 6, 2009 at 11:00 PM
Subject: [PATCH] powerpc: Export cacheable_memzero as its now used in a driver
To: linuxppc-dev@ozlabs.org


The Freescale PowerPC specific gianfar driver (gig-e) uses
cacheable_memzero for performance reasons we need to export
the symbol to allow the driver to be built as a module.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 arch/powerpc/kernel/ppc_ksyms.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/kernel/ppc_ksyms.c b/arch/powerpc/kernel/ppc_ksyms.c
index dcec132..c8b27bb 100644
--- a/arch/powerpc/kernel/ppc_ksyms.c
+++ b/arch/powerpc/kernel/ppc_ksyms.c
@@ -165,6 +165,7 @@ EXPORT_SYMBOL(timer_interrupt);
 EXPORT_SYMBOL(irq_desc);
 EXPORT_SYMBOL(tb_ticks_per_jiffy);
 EXPORT_SYMBOL(cacheable_memcpy);
+EXPORT_SYMBOL(cacheable_memzero);
 #endif

 #ifdef CONFIG_PPC32
--
1.5.6.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-01-09 18:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-29  5:41 2.6.28-git1 gianfar compile failure (ppc) Dave Jones
2009-01-09 18:10 ` Andy Fleming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).