From: Holger Eitzenberger <holger@eitzenberger.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, fubar@us.ibm.com
Subject: Re: [patch 08/10] 802.3ad: remove public lacpdu_header
Date: Mon, 29 Dec 2008 17:15:41 +0100 [thread overview]
Message-ID: <20081229161541.GA19173@mail.eitzenberger.org> (raw)
In-Reply-To: <20081226.134537.212403770.davem@davemloft.net>
On Fri, Dec 26, 2008 at 01:45:37PM -0800, David Miller wrote:
> > > - skb = dev_alloc_skb(length);
> > > - if (!skb) {
> > > + skb = dev_alloc_skb(len);
> > > + if (skb == NULL)
> >
> > "!skb" is preferred to the long-winded "skb == NULL", so
> > I'm tossing this patch and the rest which touch similar
> > areas.
>
> Also, I want to mention that your C++ comment conversions are not in
> the proper coding style as well. You are doing:
As I'm currently offline most of the time I'll resend once I'm back
home.
Thanks for your feedback!
/holger
next prev parent reply other threads:[~2008-12-29 16:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-23 22:01 [patch 00/10] bonding updates for net-next-2.6 Holger Eitzenberger
2008-12-23 22:01 ` [patch 01/10] 802.3ad: make ntt bool Holger Eitzenberger
2008-12-26 19:18 ` David Miller
2008-12-23 22:01 ` [patch 02/10] 802.3ad: turn ports is_enabled into a bool Holger Eitzenberger
2008-12-26 21:27 ` David Miller
2008-12-23 22:01 ` [patch 03/10] 802.3ad: turn ports is_individual " Holger Eitzenberger
2008-12-26 21:27 ` David Miller
2008-12-23 22:01 ` [patch 04/10] 802.3ad: remove typedef around ad_system Holger Eitzenberger
2008-12-26 21:28 ` David Miller
2008-12-23 22:01 ` [patch 05/10] 802.3ad: initialize ports LACPDU from const initializer Holger Eitzenberger
2008-12-26 21:28 ` David Miller
2008-12-23 22:01 ` [patch 06/10] 802.3ad: generalize out mac address initializer Holger Eitzenberger
2008-12-26 21:40 ` David Miller
2008-12-23 22:01 ` [patch 07/10] 802.3ad: use standard ethhdr instead of ad_header Holger Eitzenberger
2008-12-26 21:41 ` David Miller
2008-12-23 22:01 ` [patch 08/10] 802.3ad: remove public lacpdu_header Holger Eitzenberger
2008-12-26 21:43 ` David Miller
2008-12-26 21:45 ` David Miller
2008-12-29 16:15 ` Holger Eitzenberger [this message]
2008-12-23 22:01 ` [patch 09/10] 802.3ad: remove public bond_marker_header Holger Eitzenberger
2008-12-23 22:01 ` [patch 10/10] 802.3ad: cleanup around lacpdu and bond_marker Holger Eitzenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081229161541.GA19173@mail.eitzenberger.org \
--to=holger@eitzenberger.org \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).