From: Stephen Hemminger <shemminger@vyatta.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Don Skidmore <donald.c.skidmore@intel.com>
Cc: netdev@vger.kernel.org
Subject: ixgbe select_queue broken in 2.6.28
Date: Thu, 1 Jan 2009 22:54:56 -0800 [thread overview]
Message-ID: <20090101225456.68f4fe9d@extreme> (raw)
The ixgbe driver in 2.6.28 modifies select_queue. This is bad
in a couple of ways:
1) select_queue is now in net_device_ops so the driver won't build
unless CONFIG_COMPAT_NET_DEV_OPS is defined
2) it is changing data that is shared and supposed to be immutable.
Looks like a some of the DCB stuff forgot to look at net_device_ops
next reply other threads:[~2009-01-02 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-02 6:54 Stephen Hemminger [this message]
2009-01-02 8:19 ` ixgbe select_queue broken in 2.6.28 David Miller
2009-01-05 3:23 ` Waskiewicz Jr, Peter P
2009-01-05 5:36 ` David Miller
2009-01-06 13:02 ` Herbert Xu
2009-01-06 18:40 ` Waskiewicz Jr, Peter P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090101225456.68f4fe9d@extreme \
--to=shemminger@vyatta.com \
--cc=donald.c.skidmore@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).