From: Karsten Keil <kkeil@suse.de>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: kkeil@suse.de, netdev@vger.kernel.org
Subject: Re: [PATCH] isdn: capi: &&/|| typos
Date: Fri, 2 Jan 2009 13:16:30 +0100 [thread overview]
Message-ID: <20090102121630.GA14957@pingi.kke.suse.de> (raw)
In-Reply-To: <495A14AA.2060200@gmail.com>
On Tue, Dec 30, 2008 at 01:31:38PM +0100, Roel Kluin wrote:
> Correct two typos.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Karsten Keil <kkeil@suse.de>
> ---
> diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c
> index d5b4cc3..6501202 100644
> --- a/drivers/isdn/capi/capidrv.c
> +++ b/drivers/isdn/capi/capidrv.c
> @@ -1519,7 +1519,7 @@ static int decodeFVteln(char *teln, unsigned long *bmaskp, int *activep)
> int digit2 = 0;
> if (!isdigit(*s)) return -3;
> while (isdigit(*s)) { digit1 = digit1*10 + (*s - '0'); s++; }
> - if (digit1 <= 0 && digit1 > 30) return -4;
> + if (digit1 <= 0 || digit1 > 30) return -4;
> if (*s == 0 || *s == ',' || *s == ' ') {
> bmask |= (1 << digit1);
> digit1 = 0;
> @@ -1530,7 +1530,7 @@ static int decodeFVteln(char *teln, unsigned long *bmaskp, int *activep)
> s++;
> if (!isdigit(*s)) return -3;
> while (isdigit(*s)) { digit2 = digit2*10 + (*s - '0'); s++; }
> - if (digit2 <= 0 && digit2 > 30) return -4;
> + if (digit2 <= 0 || digit2 > 30) return -4;
> if (*s == 0 || *s == ',' || *s == ' ') {
> if (digit1 > digit2)
> for (i = digit2; i <= digit1 ; i++)
--
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
next prev parent reply other threads:[~2009-01-02 12:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-30 12:31 [PATCH] isdn: capi: &&/|| typos Roel Kluin
2009-01-02 12:16 ` Karsten Keil [this message]
2009-01-05 0:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090102121630.GA14957@pingi.kke.suse.de \
--to=kkeil@suse.de \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).