netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: [2/2] gro: Add page frag support
Date: Sun, 04 Jan 2009 16:13:53 -0800 (PST)	[thread overview]
Message-ID: <20090104.161353.255048732.davem@davemloft.net> (raw)
In-Reply-To: <20090102042011.GA20920@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 2 Jan 2009 15:20:11 +1100

> Here's an updated version with a redundant blank line removed.
> 
> gro: Add page frag support
> 
> This patch allows GRO to merge page frags (skb_shinfo(skb)->frags)
> in one skb, rather than using the less efficient frag_list.
> 
> It also adds a new interface, napi_gro_frags to allow drivers
> to inject page frags directly into the stack without allocating
> an skb.  This is intended to be the GRO equivalent for LRO's
> lro_receive_frags interface.
> 
> The existing GSO interface can already handle page frags with
> or without an appended frag_list so nothing needs to be changed
> there.
> 
> The merging itself is rather simple.  We store any new frag entries
> after the last existing entry, without checking whether the first
> new entry can be merged with the last existing entry.  Making this
> check would actually be easy but since no existing driver can
> produce contiguous frags anyway it would just be mental masturbation.
> 
> If the total number of entries would exceed the capacity of a
> single skb, we simply resort to using frag_list as we do now.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Also applied, thanks Herbert.

  reply	other threads:[~2009-01-05  0:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-26 22:51 [UNTESTED] gro: Add page frag support Herbert Xu
2008-12-26 23:13 ` Herbert Xu
2008-12-29 12:24 ` Herbert Xu
2008-12-30  7:07   ` David Miller
2008-12-30 10:07     ` [1/2] gro: Use gso_size to store MSS Herbert Xu
2008-12-30 10:08       ` [2/2] gro: Add page frag support Herbert Xu
2009-01-02  4:20         ` Herbert Xu
2009-01-05  0:13           ` David Miller [this message]
2009-01-05  0:13       ` [1/2] gro: Use gso_size to store MSS David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090104.161353.255048732.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).