* [Patch 1/1] tun: signedness warning
@ 2009-01-01 10:55 Gerrit Renker
2009-01-05 1:14 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Gerrit Renker @ 2009-01-01 10:55 UTC (permalink / raw)
To: netdev
tun: Eliminate sparse signedness warning
register_pernet_gen_device() expects 'int*', found via sparse.
CHECK drivers/net/tun.c
drivers/net/tun.c:1245:36: warning: incorrect type in argument 1 (different signedness)
drivers/net/tun.c:1245:36: expected int *id
drivers/net/tun.c:1245:36: got unsigned int static [toplevel] *<noident>
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
---
tun.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -213,7 +213,7 @@ static int check_filter(struct tap_filter *filter, const struct sk_buff *skb)
/* Network device part of the driver */
-static unsigned int tun_net_id;
+static int tun_net_id;
struct tun_net {
struct list_head dev_list;
};
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Patch 1/1] tun: signedness warning
2009-01-01 10:55 [Patch 1/1] tun: signedness warning Gerrit Renker
@ 2009-01-05 1:14 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-01-05 1:14 UTC (permalink / raw)
To: gerrit; +Cc: netdev
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Thu, 1 Jan 2009 11:55:57 +0100
> tun: Eliminate sparse signedness warning
>
> register_pernet_gen_device() expects 'int*', found via sparse.
>
> CHECK drivers/net/tun.c
> drivers/net/tun.c:1245:36: warning: incorrect type in argument 1 (different signedness)
> drivers/net/tun.c:1245:36: expected int *id
> drivers/net/tun.c:1245:36: got unsigned int static [toplevel] *<noident>
>
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Applied, thanks Gerrit.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-05 1:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-01 10:55 [Patch 1/1] tun: signedness warning Gerrit Renker
2009-01-05 1:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).