From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: ilpo.jarvinen@helsinki.fi, snakebyte@gmx.de,
netdev@vger.kernel.org, yoshfuji@linux-ipv6.org,
yanghy@cn.fujitsu.com
Subject: Re: [BUG] icmpv6fuzz creates bad paging request
Date: Sun, 04 Jan 2009 17:28:21 -0800 (PST) [thread overview]
Message-ID: <20090104.172821.105803003.davem@davemloft.net> (raw)
In-Reply-To: <20090102090515.GA25796@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 2 Jan 2009 20:05:15 +1100
> On Fri, Jan 02, 2009 at 08:53:18AM +0000, Ilpo Järvinen wrote:
> >
> > Can you try the patch below.
>
> You beat me to it :)
I applied Ilpo's version, because he won :-) Thanks everyone.
> > I wonder btw what's the correct policy wrt. those optval == NULL checks
> > that's visible in the patch' context (IPV6_PKTINFO is the only one which
> > is doing that while many there fetch to sizeof(struct something)).
>
> copy_from_user will catch bogus pointers so no extra checks are
> necessary.
Right.
next prev parent reply other threads:[~2009-01-05 1:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-01 20:13 [BUG] icmpv6fuzz creates bad paging request Eric Sesterhenn
2009-01-02 8:53 ` Ilpo Järvinen
2009-01-02 9:05 ` Herbert Xu
2009-01-05 1:28 ` David Miller [this message]
2009-01-02 10:28 ` Eric Sesterhenn
2009-01-02 8:59 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090104.172821.105803003.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
--cc=snakebyte@gmx.de \
--cc=yanghy@cn.fujitsu.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).