From: David Miller <davem@davemloft.net>
To: oliver@hartkopp.net
Cc: jaswinder@infradead.org, jgarzik@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org, mchan@broadcom.com,
mike@marineau.org
Subject: Re: [PATCH -net-next 3/4] firmware: convert tg3 driver to request_firmware()
Date: Mon, 05 Jan 2009 16:01:12 -0800 (PST) [thread overview]
Message-ID: <20090105.160112.119906029.davem@davemloft.net> (raw)
In-Reply-To: <49620AFE.6040409@hartkopp.net>
From: Oliver Hartkopp <oliver@hartkopp.net>
Date: Mon, 05 Jan 2009 14:28:30 +0100
> 2. I got this inconsistent lock state, i've not seen before:
I know what causes it. It's this change:
commit 22604c866889c4b2e12b73cbf1683bda1b72a313
Author: Michael Marineau <mike@marineau.org>
Date: Sun Jan 4 17:18:51 2009 -0800
net: Fix for initial link state in 2.6.28
It causes us to now call the linkwatch even trigger code inside of
software interrupt context, but that is illegal because that code path
takes the dev_base_lock rwlock as a writer.
I'm going to revert, and Michael will need to find a way to fix the
initial link state issue without adding locking problems :-)
next prev parent reply other threads:[~2009-01-06 0:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-30 8:41 [PATCH -net-next 3/4] firmware: convert tg3 driver to request_firmware() Jaswinder Singh Rajput
2009-01-05 0:11 ` David Miller
2009-01-05 13:28 ` Oliver Hartkopp
2009-01-05 13:58 ` Oliver Hartkopp
2009-01-05 14:12 ` Jaswinder Singh Rajput
2009-01-05 14:22 ` David Woodhouse
2009-01-05 14:47 ` Jaswinder Singh Rajput
2009-01-05 14:58 ` Oliver Hartkopp
2009-01-05 15:06 ` Jaswinder Singh Rajput
2009-01-06 0:01 ` David Miller [this message]
2009-01-07 3:17 ` Michael Marineau
2009-01-07 9:31 ` Oliver Hartkopp
2009-01-07 23:06 ` Michael Marineau
2009-01-13 0:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090105.160112.119906029.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jaswinder@infradead.org \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=mike@marineau.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).