From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: akpm@linux-foundation.org, netdev@vger.kernel.org,
bugme-daemon@bugzilla.kernel.org
Subject: Re: [PATCH] Re: [Bugme-new] [Bug 11571] New: u32_classify Kernel Panic
Date: Mon, 05 Jan 2009 18:14:51 -0800 (PST) [thread overview]
Message-ID: <20090105.181451.193271284.davem@davemloft.net> (raw)
In-Reply-To: <20090105135245.GC4460@ff.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Mon, 5 Jan 2009 13:52:45 +0000
> pkt_sched: cls_u32: Fix locking in u32_change()
>
> New nodes are inserted in u32_change() under rtnl_lock() with wmb(),
> so without tcf_tree_lock() like in other classifiers (e.g. cls_fw).
> This isn't enough without rmb() on the read side, but on the other
> hand adding such barriers doesn't give any savings, so the lock is
> added instead.
>
> Reported-by: m0sia <m0sia@plotinka.ru>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Applied and queued up for -stable, thanks Jarek.
next prev parent reply other threads:[~2009-01-06 2:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-11571-10286@http.bugzilla.kernel.org/>
2008-09-16 16:15 ` [Bugme-new] [Bug 11571] New: u32_classify Kernel Panic Andrew Morton
2008-09-17 19:38 ` Jarek Poplawski
2008-09-17 22:08 ` Jarek Poplawski
2008-09-18 7:05 ` m0sia
2008-09-18 7:53 ` Jarek Poplawski
2009-01-05 13:52 ` [PATCH] " Jarek Poplawski
2009-01-06 2:14 ` David Miller [this message]
2008-10-11 11:17 ` pkt_sched: cls_u32: Fix locking in u32_delete() Jarek Poplawski
2008-10-11 14:10 ` Herbert Xu
2008-10-11 19:24 ` David Miller
2008-10-11 22:04 ` Jarek Poplawski
2008-10-11 22:05 ` David Miller
2008-10-13 6:46 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090105.181451.193271284.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).