From: Jens Axboe <jens.axboe@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: buytenh@wantstofly.org, ben@zeus.com, opurdila@ixiacom.com,
jarkao2@gmail.com, netdev@vger.kernel.org
Subject: Re: splice from half-closed socket returning -EAGAIN
Date: Mon, 5 Jan 2009 09:03:22 +0100 [thread overview]
Message-ID: <20090105080321.GY32491@kernel.dk> (raw)
In-Reply-To: <20090104.235946.90553420.davem@davemloft.net>
On Sun, Jan 04 2009, David Miller wrote:
> From: Lennert Buytenhek <buytenh@wantstofly.org>
> Date: Mon, 5 Jan 2009 07:47:29 +0100
>
> > tcp: don't mask EOF and socket errors on nonblocking splice receive
> >
> > Currently, setting SPLICE_F_NONBLOCK on splice from a TCP socket
> > results in masking of EOF (RDHUP) and error conditions on the socket
> > by an -EAGAIN return. Move the NONBLOCK check in tcp_splice_read()
> > to be after the EOF and error checks to fix this.
> >
> > Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
>
> This change looks like the perfect fix for this problem.
>
> I'll apply this, thanks Lennert!
Indeed, you can add my acked-by as well if you want.
--
Jens Axboe
next prev parent reply other threads:[~2009-01-05 8:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-04 13:30 splice from half-closed socket returning -EAGAIN Lennert Buytenhek
2009-01-05 6:47 ` Lennert Buytenhek
2009-01-05 7:59 ` David Miller
2009-01-05 8:03 ` Jens Axboe [this message]
2009-01-05 8:11 ` Jarek Poplawski
2009-01-05 8:14 ` David Miller
2009-01-05 8:22 ` Jarek Poplawski
2009-01-05 8:52 ` David Miller
2009-01-05 8:54 ` David Miller
2009-01-05 8:28 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090105080321.GY32491@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=ben@zeus.com \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox