From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: [2/2] vlan: Add GRO interfaces
Date: Tue, 06 Jan 2009 10:50:17 -0800 (PST) [thread overview]
Message-ID: <20090106.105017.124602241.davem@davemloft.net> (raw)
In-Reply-To: <20090106071216.GB27281@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 6 Jan 2009 18:12:16 +1100
> vlan: Add GRO interfaces
>
> This patch adds GRO interfaces for hardware-assisted VLAN reception.
> With this in place we're now at parity with LRO as far as the
> interface is concerned. That is, you can now take any LRO driver
> and convert it over to GRO.
>
> As the CB memory clashes with GRO's use of CB, I've removed it
> entirely by storing dev in skb->dev. This is OK because VLAN
> gets called first thing in netif_receive_skb and skb->dev is
> not used in between us calling netif_rx and netif_receive_skb
> getting called.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Also applied, thanks Herbert.
next prev parent reply other threads:[~2009-01-06 18:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-02 5:47 [UNTESTED] Add hardware-assisted VLAN support for GRO Herbert Xu
2009-01-02 5:49 ` Herbert Xu
2009-01-05 6:57 ` David Miller
2009-01-05 9:47 ` Herbert Xu
2009-01-05 9:51 ` Herbert Xu
2009-01-06 7:11 ` [1/2] gro: Add internal interfaces for VLAN Herbert Xu
2009-01-06 7:12 ` [2/2] vlan: Add GRO interfaces Herbert Xu
2009-01-06 18:50 ` David Miller [this message]
2009-01-06 18:49 ` [1/2] gro: Add internal interfaces for VLAN David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090106.105017.124602241.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).