From: David Miller <davem@davemloft.net>
To: oliver@hartkopp.net
Cc: urs.thuermann@volkswagen.de, netdev@vger.kernel.org
Subject: Re: [RESEND] can: omit unneeded skb_clone() calls
Date: Tue, 06 Jan 2009 11:08:01 -0800 (PST) [thread overview]
Message-ID: <20090106.110801.170679549.davem@davemloft.net> (raw)
In-Reply-To: <4963300E.6010605@hartkopp.net>
From: Oliver Hartkopp <oliver@hartkopp.net>
Date: Tue, 06 Jan 2009 11:18:54 +0100
> The AF_CAN core delivered always cloned sk_buffs to the AF_CAN
> protocols, although this was _only_ needed by the can-raw protocol.
> With this (additionally documented) change, the AF_CAN core calls the
> callback functions of the registered AF_CAN protocols with the original
> (uncloned) sk_buff pointer and let's the can-raw protocol do the
> skb_clone() itself which omits all unneeded skb_clone() calls for other
> AF_CAN protocols.
>
> Signed-off-by: Oliver Hartkopp <oliver@hartkopp.net>
> Signed-off-by: Urs Thuermann <urs.thuermann@volkswagen.de>
Applied.
prev parent reply other threads:[~2009-01-06 19:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 10:18 [RESEND] can: omit unneeded skb_clone() calls Oliver Hartkopp
2009-01-06 19:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090106.110801.170679549.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oliver@hartkopp.net \
--cc=urs.thuermann@volkswagen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).