From: Stephen Hemminger <shemminger@vyatta.com>
To: Wang Chen <wangchen@cn.fujitsu.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] pcnet32: round off carrier watch timer
Date: Wed, 7 Jan 2009 16:38:19 -0800 [thread overview]
Message-ID: <20090107163819.3ef02507@extreme> (raw)
In-Reply-To: <496549AF.3050500@cn.fujitsu.com>
On Thu, 08 Jan 2009 08:32:47 +0800
Wang Chen <wangchen@cn.fujitsu.com> wrote:
> Stephen Hemminger said the following on 2009-1-8 4:10:
> > The link check watchdog timer on this driver fires every two seconds, but
> > since not aligned it causes extra wakeups. It is more important on this
> > driver than most because it is the hardware that is emulated by default
> > when using network interfaces on VMware.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> >
> > --- a/drivers/net/pcnet32.c 2009-01-07 12:05:54.218712996 -0800
> > +++ b/drivers/net/pcnet32.c 2009-01-07 12:06:37.430288101 -0800
> > @@ -2282,7 +2282,7 @@ static int pcnet32_open(struct net_devic
> > if (lp->chip_version >= PCNET32_79C970A) {
> > /* Print the link status and start the watchdog */
> > pcnet32_check_media(dev, 1);
> > - mod_timer(&(lp->watchdog_timer), PCNET32_WATCHDOG_TIMEOUT);
> > + mod_timer(&lp->watchdog_timer, PCNET32_WATCHDOG_TIMEOUT);
>
> should be
> + mod_timer(&lp->watchdog_timer, round_jiffies(PCNET32_WATCHDOG_TIMEOUT));
> same as that in pcnet32_watchdog()?
It only gets run on the first tick so it doesn't matter.
next prev parent reply other threads:[~2009-01-08 0:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 20:10 [PATCH] pcnet32: round off carrier watch timer Stephen Hemminger
2009-01-08 0:32 ` Wang Chen
2009-01-08 0:38 ` Stephen Hemminger [this message]
2009-01-08 19:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090107163819.3ef02507@extreme \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).