netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch]switch kaweth driver to netdevops
@ 2009-01-08 13:22 Oliver Neukum
       [not found] ` <200901081422.55536.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Oliver Neukum @ 2009-01-08 13:22 UTC (permalink / raw)
  To: netdev-u79uwXL29TY76Z2rM5mHXA
  Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q, linux-usb-u79uwXL29TY76Z2rM5mHXA

This converts the kaweth ethernet USB driver to netdevops.

Signed-off-by: Oliver Neukum<oneukum-l3A5Bk7waGM@public.gmane.org>

	Regards
		Oliver

commit f439f3ec3c68586f92dd692f220e44fd898a50bb
Author: Oliver Neukum <oneukum-l3A5Bk7waGM@public.gmane.org>
Date:   Wed Jan 7 14:31:21 2009 +0100

    convert kaweth to new netdev ops

diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c
index 2ee034f..e166b87 100644
--- a/drivers/net/usb/kaweth.c
+++ b/drivers/net/usb/kaweth.c
@@ -251,7 +251,6 @@ struct kaweth_device
 	struct net_device_stats stats;
 };
 
-
 /****************************************************************
  *     kaweth_control
  ****************************************************************/
@@ -975,6 +974,17 @@ static int kaweth_resume(struct usb_interface *intf)
 /****************************************************************
  *     kaweth_probe
  ****************************************************************/
+
+
+static const struct net_device_ops kaweth_netdev_ops = {
+	.ndo_open =			kaweth_open,
+	.ndo_stop =			kaweth_close,
+	.ndo_start_xmit =		kaweth_start_xmit,
+	.ndo_tx_timeout =		kaweth_tx_timeout,
+	.ndo_set_multicast_list =	kaweth_set_rx_mode,
+	.ndo_get_stats =		kaweth_netdev_stats,
+};
+
 static int kaweth_probe(
 		struct usb_interface *intf,
 		const struct usb_device_id *id      /* from id_table */
@@ -1147,22 +1157,13 @@ err_fw:
 	memcpy(netdev->dev_addr, &kaweth->configuration.hw_addr,
                sizeof(kaweth->configuration.hw_addr));
 
-	netdev->open = kaweth_open;
-	netdev->stop = kaweth_close;
-
+	netdev->netdev_ops = &kaweth_netdev_ops;
 	netdev->watchdog_timeo = KAWETH_TX_TIMEOUT;
-	netdev->tx_timeout = kaweth_tx_timeout;
-
-	netdev->hard_start_xmit = kaweth_start_xmit;
-	netdev->set_multicast_list = kaweth_set_rx_mode;
-	netdev->get_stats = kaweth_netdev_stats;
 	netdev->mtu = le16_to_cpu(kaweth->configuration.segment_size);
 	SET_ETHTOOL_OPS(netdev, &ops);
 
 	/* kaweth is zeroed as part of alloc_netdev */
-
 	INIT_DELAYED_WORK(&kaweth->lowmem_work, kaweth_resubmit_tl);

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [patch]switch kaweth driver to netdevops
       [not found] ` <200901081422.55536.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
@ 2009-01-08 19:20   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-01-08 19:20 UTC (permalink / raw)
  To: oliver-GvhC2dPhHPQdnm+yROfE0A
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA

From: Oliver Neukum <oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
Date: Thu, 8 Jan 2009 14:22:54 +0100

> This converts the kaweth ethernet USB driver to netdevops.
> 
> Signed-off-by: Oliver Neukum<oneukum-l3A5Bk7waGM@public.gmane.org>

Applied, thank you.

You might want to put a space before your email address in
that signoff line :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch]switch kaweth driver to netdevops
@ 2009-01-09  3:51 Herbert Xu
  0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2009-01-09  3:51 UTC (permalink / raw)
  To: davem; +Cc: oliver, netdev, linux-usb

David Miller <davem@davemloft.net> wrote:
> From: Oliver Neukum <oliver@neukum.org>
> Date: Thu, 8 Jan 2009 14:22:54 +0100
> 
>> This converts the kaweth ethernet USB driver to netdevops.
>> 
>> Signed-off-by: Oliver Neukum<oneukum@suse.de>
> 
> Applied, thank you.
> 
> You might want to put a space before your email address in
> that signoff line :-)

Spacesareatapremiumthesedays:)
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-01-09  3:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-08 13:22 [patch]switch kaweth driver to netdevops Oliver Neukum
     [not found] ` <200901081422.55536.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2009-01-08 19:20   ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2009-01-09  3:51 Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).