From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: jgarzik@pobox.com, bhutchings@solarflare.com, rick.jones2@hp.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] Make possible speeds known to ethtool
Date: Thu, 08 Jan 2009 21:00:58 -0800 (PST) [thread overview]
Message-ID: <20090108.210058.68468127.davem@davemloft.net> (raw)
In-Reply-To: <20090109041952.GA12087@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 9 Jan 2009 15:19:53 +1100
> Jeff Garzik <jgarzik@pobox.com> wrote:
> >
> > For generic net stack flags outside the driver's control, that can
> > easily be added to ethtool_{get,set}_flags() overriding or ignoring
> > whatever the driver may have done.
>
> To use the flags interface as is, you'd have to go through every
> single driver to get them to call ethtool_op_set_flags. I'm sorry
> but I'm sticking with the current interface.
Right, the flags thing is inappropriate without major reworking for
Herbert's GRO case and therefore his choice was completely
appropriate.
next prev parent reply other threads:[~2009-01-09 5:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 4:19 [PATCH] Make possible speeds known to ethtool Herbert Xu
2009-01-09 5:00 ` David Miller [this message]
2009-01-09 5:05 ` Jeff Garzik
2009-01-09 5:03 ` Jeff Garzik
2009-01-09 5:15 ` Herbert Xu
2009-01-09 5:30 ` Jeff Garzik
2009-01-09 5:35 ` Herbert Xu
2009-01-09 6:28 ` Jeff Garzik
2009-01-09 6:30 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2009-01-09 3:48 Herbert Xu
2009-01-09 3:58 ` Jeff Garzik
2009-01-08 2:03 Rick Jones
2009-01-08 3:14 ` Ben Hutchings
2009-01-08 3:12 ` Jeff Garzik
2009-01-08 19:11 ` Rick Jones
2009-01-08 19:25 ` Ben Hutchings
2009-01-08 19:50 ` Rick Jones
2009-01-09 2:52 ` Herbert Xu
2009-01-09 3:20 ` Jeff Garzik
2009-03-06 11:19 ` Jeff Garzik
2009-03-06 13:52 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090108.210058.68468127.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=herbert@gondor.apana.org.au \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).