From: Rick Jones <rick.jones2@hp.com>
To: davem@davemloft.net, jgarzik@pobox.com, netdev@vger.kernel.org
Subject: [PATCH] Make possible speeds known to ethtool
Date: Wed, 7 Jan 2009 18:03:31 -0800 (PST) [thread overview]
Message-ID: <200901080203.SAA19103@tardy.cup.hp.com> (raw)
Certain Broadcom 10Gb Ethernet solutions (e.g. the 57711E) can have a
10Gb port split into multiple virtual NICs each with an instance of
the bnx2x driver. These virtual NICs can be configured for any speed
which is an integer multiple of 100 Mb/s from 100 to 10,000 Mbit/s
inclusive. Since this is "normal" for such systems an "Unknown!" is
not indicated.
Signed-off-by: Rick Jones <rick.jones2@hp.com>
---
Rather than make a wholesale change to the existing "speed vetting"
code, it seemed least invasive to escape-out to a new routine in the
default case. Should other "unfamiliar" speeds surface in the future
the checks can be put there.
Where the original would say this:
Speed: Unknown! (1600)
for a FlexNIC link set to 1600 Mbit/s the changed version will
say:
Speed: 1600Mb/s
There is presently no way to alter this speed setting from within the
host, so there is no need/point to altering the ethtool "set" path.
--- ethtool.c.orig 2008-11-17 11:53:40.000000000 -0800
+++ ethtool.c 2008-11-17 13:14:55.000000000 -0800
@@ -806,6 +806,14 @@ static void dump_advertised(struct ethto
fprintf(stdout, "No\n");
}
+static void vet_unfamiliar_speed(struct ethtool_cmd *ep)
+{
+ if ((!ep->speed) || (ep->speed % 100))
+ fprintf(stdout, "Unknown! (%i)\n", ep->speed);
+ else
+ fprintf(stdout,"%dMb/s\n",ep->speed);
+}
+
static int dump_ecmd(struct ethtool_cmd *ep)
{
dump_supported(ep);
@@ -829,7 +837,7 @@ static int dump_ecmd(struct ethtool_cmd
fprintf(stdout, "10000Mb/s\n");
break;
default:
- fprintf(stdout, "Unknown! (%i)\n", ep->speed);
+ vet_unfamiliar_speed(ep);
break;
};
next reply other threads:[~2009-01-08 2:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 2:03 Rick Jones [this message]
2009-01-08 3:14 ` [PATCH] Make possible speeds known to ethtool Ben Hutchings
2009-01-08 3:12 ` Jeff Garzik
2009-01-08 19:11 ` Rick Jones
2009-01-08 19:25 ` Ben Hutchings
2009-01-08 19:50 ` Rick Jones
2009-01-09 13:16 ` [PATCH] ethtool: Support arbitrary speeds Ben Hutchings
2009-01-09 17:55 ` Rick Jones
2009-01-09 18:24 ` Ben Hutchings
2009-01-09 18:40 ` Rick Jones
2009-03-06 11:20 ` Jeff Garzik
2009-03-06 12:27 ` Jeff Garzik
2009-01-09 2:52 ` [PATCH] Make possible speeds known to ethtool Herbert Xu
2009-01-09 3:20 ` Jeff Garzik
2009-03-06 11:19 ` Jeff Garzik
2009-03-06 13:52 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2009-01-09 3:48 Herbert Xu
2009-01-09 3:58 ` Jeff Garzik
2009-01-09 4:19 Herbert Xu
2009-01-09 5:00 ` David Miller
2009-01-09 5:05 ` Jeff Garzik
2009-01-09 5:03 ` Jeff Garzik
2009-01-09 5:15 ` Herbert Xu
2009-01-09 5:30 ` Jeff Garzik
2009-01-09 5:35 ` Herbert Xu
2009-01-09 6:28 ` Jeff Garzik
2009-01-09 6:30 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901080203.SAA19103@tardy.cup.hp.com \
--to=rick.jones2@hp.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).