From: Evgeniy Polyakov <zbr@ioremap.net>
To: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
liranl@mellanox.co.il, tziporet@mellanox.co.il
Subject: Re: IP LRO
Date: Thu, 8 Jan 2009 12:17:56 +0300 [thread overview]
Message-ID: <20090108091755.GA23458@ioremap.net> (raw)
In-Reply-To: <4965BF43.1060801@mellanox.co.il>
Hi Yevgeny.
On Thu, Jan 08, 2009 at 10:54:27AM +0200, Yevgeny Petrilin (yevgenyp@mellanox.co.il) wrote:
> We have recently implemented a reassembly of fragmented IP packets in
> mlx4_en driver. This offload gives a performance boost in case of incoming
> traffic with fragmented packets (such as UDP traffic with message size larger
> then MTU). The attached patch contains this offload. I believe that we can make
> this code generic, maybe part of inet_lro.
> Please review and comment.
Frankly from the patch it is quite hard to tell if it is suitable or not
for the generic usage. For example no structure access or lookup are
guarded with some locks, likely they are somewhere in the driver itself,
so at least it should be documented. Fragment structure can be
rearranged to better fit the alignment rules of the platform (there are
gaps even on 32bit). Please provide higher-level description on how it
operates compared to existing GRO/LRO (except that it is one layer lower),
how strcutres are operated, what are the lifetime rules for them and
appropriate skbs, what are the usage case. How will it live with
GRO/LRO, i.e. who will steal the skb if it matches both subsystems.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2009-01-08 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 8:54 IP LRO Yevgeny Petrilin
2009-01-08 9:17 ` Evgeniy Polyakov [this message]
2009-01-08 10:35 ` Yevgeny Petrilin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090108091755.GA23458@ioremap.net \
--to=zbr@ioremap.net \
--cc=davem@davemloft.net \
--cc=liranl@mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=tziporet@mellanox.co.il \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).