* Re: [PATCH] net: fix section mismatch warnings in dccp/ccids/lib/tfrc.c [not found] <200901081957.03413.lpotenza@inwind.it> @ 2009-01-08 23:28 ` Arnaldo Carvalho de Melo 2009-01-08 23:43 ` David Miller 0 siblings, 1 reply; 4+ messages in thread From: Arnaldo Carvalho de Melo @ 2009-01-08 23:28 UTC (permalink / raw) To: Leonardo Potenza, David Miller, Gerrit Renker Cc: kernel-janitors, linux-kernel, DCCP Mailing List, Linux Networking Development Mailing List Adding netdev to the CC list. Em Thu, Jan 08, 2009 at 07:57:03PM +0100, Leonardo Potenza escreveu: > From: Leonardo Potenza <lpotenza@inwind.it> > > Removed the __exit annotation of tfrc_lib_exit(), in order to suppress the following section mismatch messages: > > WARNING: net/dccp/dccp.o(.text+0xd9): Section mismatch in reference from the function ccid_cleanup_builtins() to the function .exit.text:tfrc_lib_exit() > The function ccid_cleanup_builtins() references a function in an exit section. > Often the function tfrc_lib_exit() has valid usage outside the exit section > and the fix is to remove the __exit annotation of tfrc_lib_exit. > > WARNING: net/dccp/dccp.o(.init.text+0x48): Section mismatch in reference from the function ccid_initialize_builtins() to the function .exit.text:tfrc_lib_exit() > The function __init ccid_initialize_builtins() references > a function __exit tfrc_lib_exit(). > This is often seen when error handling in the init function > uses functionality in the exit path. > The fix is often to remove the __exit annotation of > tfrc_lib_exit() so it may be used outside an exit section. > > Signed-off-by: Leonardo Potenza <lpotenza@inwind.it> > --- > Index: linux-2.6/net/dccp/ccids/lib/tfrc.c > =================================================================== > --- linux-2.6.orig/net/dccp/ccids/lib/tfrc.c 2009-01-08 19:19:50.000000000 +0100 > +++ linux-2.6/net/dccp/ccids/lib/tfrc.c 2009-01-08 19:20:07.000000000 +0100 > @@ -36,7 +36,7 @@ out: > return rc; > } > > -void __exit tfrc_lib_exit(void) > +void tfrc_lib_exit(void) > { > tfrc_rx_packet_history_exit(); > tfrc_tx_packet_history_exit(); Thanks Leonardo, Dave/Gerrit, Please apply. Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> Thanks, - Arnaldo ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: fix section mismatch warnings in dccp/ccids/lib/tfrc.c 2009-01-08 23:28 ` [PATCH] net: fix section mismatch warnings in dccp/ccids/lib/tfrc.c Arnaldo Carvalho de Melo @ 2009-01-08 23:43 ` David Miller 2009-01-10 17:24 ` gerrit 0 siblings, 1 reply; 4+ messages in thread From: David Miller @ 2009-01-08 23:43 UTC (permalink / raw) To: acme; +Cc: lpotenza, gerrit, kernel-janitors, linux-kernel, dccp, netdev From: Arnaldo Carvalho de Melo <acme@redhat.com> Date: Thu, 8 Jan 2009 21:28:47 -0200 > Adding netdev to the CC list. ... > Dave/Gerrit, > > Please apply. > > Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> I'll take care of this, thanks! ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: fix section mismatch warnings in dccp/ccids/lib/tfrc.c 2009-01-08 23:43 ` David Miller @ 2009-01-10 17:24 ` gerrit 2009-01-11 8:11 ` David Miller 0 siblings, 1 reply; 4+ messages in thread From: gerrit @ 2009-01-10 17:24 UTC (permalink / raw) To: David Miller; +Cc: acme, lpotenza, dccp, netdev >> >> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > I'll take care of this, thanks! Thank you - if it is not too late, Acked-by: Gerrit Renker <gerrit@erg.abdn.ac.uk> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: fix section mismatch warnings in dccp/ccids/lib/tfrc.c 2009-01-10 17:24 ` gerrit @ 2009-01-11 8:11 ` David Miller 0 siblings, 0 replies; 4+ messages in thread From: David Miller @ 2009-01-11 8:11 UTC (permalink / raw) To: gerrit; +Cc: acme, lpotenza, dccp, netdev From: gerrit@erg.abdn.ac.uk Date: Sat, 10 Jan 2009 17:24:24 -0000 (GMT) > >> > >> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > > > I'll take care of this, thanks! > > Thank you - if it is not too late, > Acked-by: Gerrit Renker <gerrit@erg.abdn.ac.uk> Ack added, thanks for the review :) ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-01-11 8:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200901081957.03413.lpotenza@inwind.it>
2009-01-08 23:28 ` [PATCH] net: fix section mismatch warnings in dccp/ccids/lib/tfrc.c Arnaldo Carvalho de Melo
2009-01-08 23:43 ` David Miller
2009-01-10 17:24 ` gerrit
2009-01-11 8:11 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).