* [patch 2/4] drivers/net/hamradio/6pack.c: move a dereference below a NULL test
@ 2009-01-09 20:23 akpm
2009-01-10 7:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2009-01-09 20:23 UTC (permalink / raw)
To: davem; +Cc: netdev, akpm, julia
From: Julia Lawall <julia@diku.dk>
In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E
when != i
if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/net/hamradio/6pack.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN drivers/net/hamradio/6pack.c~drivers-net-hamradio-6packc-move-a-dereference-below-a-null-test drivers/net/hamradio/6pack.c
--- a/drivers/net/hamradio/6pack.c~drivers-net-hamradio-6packc-move-a-dereference-below-a-null-test
+++ a/drivers/net/hamradio/6pack.c
@@ -717,11 +717,12 @@ static int sixpack_ioctl(struct tty_stru
unsigned int cmd, unsigned long arg)
{
struct sixpack *sp = sp_get(tty);
- struct net_device *dev = sp->dev;
+ struct net_device *dev;
unsigned int tmp, err;
if (!sp)
return -ENXIO;
+ dev = sp->dev;
switch(cmd) {
case SIOCGIFNAME:
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 2/4] drivers/net/hamradio/6pack.c: move a dereference below a NULL test
2009-01-09 20:23 [patch 2/4] drivers/net/hamradio/6pack.c: move a dereference below a NULL test akpm
@ 2009-01-10 7:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-01-10 7:10 UTC (permalink / raw)
To: akpm; +Cc: netdev, julia
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-10 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-09 20:23 [patch 2/4] drivers/net/hamradio/6pack.c: move a dereference below a NULL test akpm
2009-01-10 7:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).