From: David Miller <davem@davemloft.net>
To: aabdulla@nvidia.com
Cc: manfred@colorfullife.com, jgarzik@pobox.com, akpm@osdl.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] forcedeth: xmit lock fix
Date: Fri, 09 Jan 2009 23:13:31 -0800 (PST) [thread overview]
Message-ID: <20090109.231331.168136341.davem@davemloft.net> (raw)
In-Reply-To: <4967BBB0.90809@nvidia.com>
From: Ayaz Abdulla <aabdulla@nvidia.com>
Date: Fri, 09 Jan 2009 16:03:44 -0500
> This patch fixes a potential race condition between xmit thread and xmit completion thread. The calculation of empty tx descriptors is not performed under the lock. This could cause it to set the stop flag while the completion thread finishes all tx's. This will result in the tx queue in stopped state and no one to wake it up.
>
> Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
Applied.
prev parent reply other threads:[~2009-01-10 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 21:03 [PATCH 2/4] forcedeth: xmit lock fix Ayaz Abdulla
2009-01-10 7:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109.231331.168136341.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aabdulla@nvidia.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=manfred@colorfullife.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).