From: David Miller <davem@davemloft.net>
To: florian@openwrt.org
Cc: jeff@garzik.org, netdev@vger.kernel.org, Joe.Chou@rdc.com.tw
Subject: Re: [PATCH 1/4] r6040: fix ifconfig down and freeing of tx/rx descriptors
Date: Fri, 09 Jan 2009 23:16:41 -0800 (PST) [thread overview]
Message-ID: <20090109.231641.79400772.davem@davemloft.net> (raw)
In-Reply-To: <20090109.230707.252449247.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Fri, 09 Jan 2009 23:07:07 -0800 (PST)
> From: Florian Fainelli <florian@openwrt.org>
> Date: Fri, 9 Jan 2009 02:04:39 +0100
>
> > Subject: [PATCH 1/4] r6040: fix ifconfig down and freeing of tx/rx descriptors
> >
> > This patch fixes warnings and such traces that appear when doing
> > an ifconfig down on the interface:
> >
> > WARNING: at arch/x86/kernel/pci-dma.c:376 dma_free_coherent+0x40/0x7d()
> > Modules linked in:
> >
> > Signed-off-by: Joe Chou <joe.chou@rdc.com.tw>
> > Signed-off-by: Florian Fainelli <florian@openwrt.org>
>
> Applied.
Actually, this breaks the build.
The problem is that there is no 'pdev' in r6040_close() where
you moved these pci_free_consistent() calls.
I guess on whatever platform you tried to compile test this,
these interfaces are macros and thus ignore the 'pdev' argument.
I'll fix this but...
prev parent reply other threads:[~2009-01-10 7:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 1:04 [PATCH 1/4] r6040: fix ifconfig down and freeing of tx/rx descriptors Florian Fainelli
2009-01-10 7:07 ` David Miller
2009-01-10 7:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109.231641.79400772.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Joe.Chou@rdc.com.tw \
--cc=florian@openwrt.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).