From: Michael Buesch <mb@bu3sch.de>
To: Felix Fietkau <nbd@openwrt.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] b44: fix misalignment and wasted space in rx handling
Date: Fri, 9 Jan 2009 11:35:37 +0100 [thread overview]
Message-ID: <200901091135.38079.mb@bu3sch.de> (raw)
In-Reply-To: <4966C21F.5020700@openwrt.org>
On Friday 09 January 2009 04:18:55 Felix Fietkau wrote:
> Broadcom 4400 puts a header of configurable size (apparently needs
> to be at least 28 bytes) in front of received packets. When handling
> this, the previous code accidentally added the offset 30 *twice* for
> the software and once for the hardware, thereby cancelling out the
> IP alignment effect of the 30 byte padding and wasting an additional
> 30 bytes of memory per packet.
>
> This patch fixes this problem and improves routing throughput by
> about 30% on MIPS, where unaligned access is expensive.
Very nice fix, indeed.
Too bad the patch is line wrapped :)
--
Greetings, Michael.
prev parent reply other threads:[~2009-01-09 10:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 3:18 [PATCH] b44: fix misalignment and wasted space in rx handling Felix Fietkau
2009-01-09 10:35 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901091135.38079.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).