netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 1/2] net/tipc/bcast.h: use ARRAY_SIZE
@ 2009-01-09 20:22 akpm
  2009-01-10  7:09 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2009-01-09 20:22 UTC (permalink / raw)
  To: davem; +Cc: netdev, akpm, julia, per.liden

From: Julia Lawall <julia@diku.dk>

ARRAY_SIZE is more concise to use when the size of an array is divided by
the size of its type or the size of its first element.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@i@
@@

#include <linux/kernel.h>

@depends on i using "paren.iso"@
type T;
T[] E;
@@

- (sizeof(E)/sizeof(T))
+ ARRAY_SIZE(E)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Per Liden <per.liden@nospam.ericsson.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 net/tipc/bcast.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN net/tipc/bcast.h~net-tipc-bcasth-use-array_size net/tipc/bcast.h
--- a/net/tipc/bcast.h~net-tipc-bcasth-use-array_size
+++ a/net/tipc/bcast.h
@@ -124,7 +124,7 @@ static inline int tipc_nmap_equal(struct
 static inline void tipc_nmap_diff(struct tipc_node_map *nm_a, struct tipc_node_map *nm_b,
 				  struct tipc_node_map *nm_diff)
 {
-	int stop = sizeof(nm_a->map) / sizeof(u32);
+	int stop = ARRAY_SIZE(nm_a->map);
 	int w;
 	int b;
 	u32 map;
_

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 1/2] net/tipc/bcast.h: use ARRAY_SIZE
  2009-01-09 20:22 [patch 1/2] net/tipc/bcast.h: use ARRAY_SIZE akpm
@ 2009-01-10  7:09 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-01-10  7:09 UTC (permalink / raw)
  To: akpm; +Cc: netdev, julia, per.liden


Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-01-10  7:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-09 20:22 [patch 1/2] net/tipc/bcast.h: use ARRAY_SIZE akpm
2009-01-10  7:09 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).