From: David Miller <davem@davemloft.net>
To: steve.glendinning@smsc.com
Cc: netdev@vger.kernel.org, ian.saturley@smsc.com
Subject: Re: [PATCH 1/2] smsc911x: fix smsc911x_reg_read compiler warning
Date: Sun, 11 Jan 2009 00:14:33 -0800 (PST) [thread overview]
Message-ID: <20090111.001433.209033327.davem@davemloft.net> (raw)
In-Reply-To: <1231594169-24988-1-git-send-email-steve.glendinning@smsc.com>
From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Sat, 10 Jan 2009 13:29:28 +0000
> if this code path is ever hit, the platform_data struct isn't properly
> configured with a bus width flag so the device won't work (hence the
> BUG()).
>
> This patch adds a dummy return statement to eliminate this compiler
> warning:
>
> drivers/net/smsc911x.c: In function 'smsc911x_reg_read':
> drivers/net/smsc911x.c:148: warning: control reaches end of non-void function
>
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Applied.
prev parent reply other threads:[~2009-01-11 8:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 13:29 [PATCH 1/2] smsc911x: fix smsc911x_reg_read compiler warning Steve Glendinning
2009-01-10 13:29 ` [PATCH 2/2] smsc911x: register irq with device name, not driver name Steve Glendinning
2009-01-11 8:14 ` David Miller
2009-01-11 8:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090111.001433.209033327.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ian.saturley@smsc.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).