From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrill Gorcunov Subject: Re: [RFC 4/4] net: ppp_generic - introduce net-namespace functionality Date: Sun, 11 Jan 2009 11:25:22 +0300 Message-ID: <20090111082522.GC7686@localhost> References: <20090109195154.320495476@gmail.com> <4967accd.0305560a.3553.ffffd187@mx.google.com> <20090110092258.GA7622@localhost> <20090110092830.GB7622@localhost> <18793.15953.591733.958862@cargo.ozlabs.ibm.com> <20090111074652.GB7686@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: James Chapman To: Paul Mackerras , davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devel@openvz.org, xemul@openvz.org Return-path: Received: from fg-out-1718.google.com ([72.14.220.156]:53909 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750946AbZAKIZ0 (ORCPT ); Sun, 11 Jan 2009 03:25:26 -0500 Content-Disposition: inline In-Reply-To: <20090111074652.GB7686@localhost> Sender: netdev-owner@vger.kernel.org List-ID: [Cyrill Gorcunov - Sun, Jan 11, 2009 at 10:46:52AM +0300] | [Paul Mackerras - Sun, Jan 11, 2009 at 11:33:21AM +1100] | | Cyrill Gorcunov writes: | | | | > From: Cyrill Gorcunov | | > Subecjt: [RFC] net: ppp_generic - introduce net-namespace functionality | | > | | > - Each namespace contain ppp channels and units separately | | > with appropriate locks | | | | This looks like a lot of uglification to me. Why exactly do | | individual network drivers need to know or care about namespaces? | | | | Paul. | | | | Unfortunately in the whole series ppp has been change more | then others and it's looks ugly indeed that is why it was RFC. | Namespaces imply isolation of data right? Including private | data being 'user related' -- ie units passed to user in one | namespace should not interfere with units passed to user in | another namespace. So if I will not 'bind' units pool to | namespaces it would be possible to steal unit from one namespace | proposed for another namespace. Right? | | - Cyrill - Anyway, thanks for review -- I'll check if I could make this series less 'ugly'. I just wanna hear what people think about this series 'in general' (or maybe even test it [James, thanks!] :) -- since the series is RFC and not to include in any kind of tree. - Cyrill -