From: Alexey Dobriyan <adobriyan@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, devel@openvz.org, xemul@openvz.org
Subject: Re: [RFC 0/4] net namespace for PPP
Date: Mon, 12 Jan 2009 00:27:00 +0300 [thread overview]
Message-ID: <20090111212700.GA4008@x200.localdomain> (raw)
In-Reply-To: <4967acca.0437560a.511e.0221@mx.google.com>
On Fri, Jan 09, 2009 at 10:51:54PM +0300, Cyrill Gorcunov wrote:
> here is a series of RFC in attempt to implement
> net-namespaces for PPP protocol (including PPPoE
> and PPPoL2TP).
You need assign netns to netdevice after alloc_netdev().
This should fix much confusion and non-bugs mentioned in this thread.
After that struct ppp shouldn't need netns pointer as it will be netns
of it's netdevice.
current->nsproxy->net_ns while being correct in ioctl context
(it's synchronous) is easy to screwup. For example, in netfilter code netns
is taken from socket on which ioctl is done.
Regardless of netns, try_module_get() calls by hand are suspicious
and they're copied to netns init hook.
next prev parent reply other threads:[~2009-01-11 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 19:51 [RFC 0/4] net namespace for PPP Cyrill Gorcunov
2009-01-09 21:32 ` Cyrill Gorcunov
2009-01-11 21:27 ` Alexey Dobriyan [this message]
2009-01-11 21:56 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090111212700.GA4008@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).