[RFC 0/4] net namespace for PPP

[RFC 0/4] net namespace for PPP

[Cyrill Gorcunov]

Hi,

here is a series of RFC in attempt to implement
net-namespaces for PPP protocol (including PPPoE
and PPPoL2TP).

I would really appreciate _any_ kind of comments.
Really doubt if there is no bugs in my implementation
but it's RFC after all. Mostly -compile- tested so it
requires strong review. One more time -- I would admire
any kind of comments (even like -- it's completely broken
and full of sh*t would be fine -- but with details please :).

		Cyrill
-- 

Re: [RFC 0/4] net namespace for PPP

[Cyrill Gorcunov]

[Cyrill Gorcunov - Fri, Jan 09, 2009 at 10:51:54PM +0300]
| Hi,
| 
| here is a series of RFC in attempt to implement
| net-namespaces for PPP protocol (including PPPoE
| and PPPoL2TP).
| 
| I would really appreciate _any_ kind of comments.
| Really doubt if there is no bugs in my implementation
| but it's RFC after all. Mostly -compile- tested so it
| requires strong review. One more time -- I would admire
| any kind of comments (even like -- it's completely broken
| and full of sh*t would be fine -- but with details please :).
| 
| 		Cyrill
| -- 
| 

Ah, forgot to mention the patches are over the
net-next-2.6 tree commit

commit 6332178d91ca1a9dbd99bd97cabbcf965d178e9f
Merge: 908a7a1... 739840d...
Author: David S. Miller <davem@davemloft.net>
Date:   Tue Dec 23 17:56:23 2008 -0800

		- Cyrill -

Re: [RFC 0/4] net namespace for PPP

[Alexey Dobriyan]

On Fri, Jan 09, 2009 at 10:51:54PM +0300, Cyrill Gorcunov wrote:
> here is a series of RFC in attempt to implement
> net-namespaces for PPP protocol (including PPPoE
> and PPPoL2TP).

You need assign netns to netdevice after alloc_netdev().
This should fix much confusion and non-bugs mentioned in this thread.

After that struct ppp shouldn't need netns pointer as it will be netns
of it's netdevice.

current->nsproxy->net_ns while being correct in ioctl context
(it's synchronous) is easy to screwup. For example, in netfilter code netns
is taken from socket on which ioctl is done.

Regardless of netns, try_module_get() calls by hand are suspicious
and they're copied to netns init hook.

Re: [RFC 0/4] net namespace for PPP

[Cyrill Gorcunov]

[Alexey Dobriyan - Mon, Jan 12, 2009 at 12:27:00AM +0300]
| On Fri, Jan 09, 2009 at 10:51:54PM +0300, Cyrill Gorcunov wrote:
| > here is a series of RFC in attempt to implement
| > net-namespaces for PPP protocol (including PPPoE
| > and PPPoL2TP).
| 
| You need assign netns to netdevice after alloc_netdev().
| This should fix much confusion and non-bugs mentioned in this thread.
| 
| After that struct ppp shouldn't need netns pointer as it will be netns
| of it's netdevice.

Good point, thanks!

| 
| current->nsproxy->net_ns while being correct in ioctl context
| (it's synchronous) is easy to screwup. For example, in netfilter code netns
| is taken from socket on which ioctl is done.

Didn't know that, will check.

| 
| Regardless of netns, try_module_get() calls by hand are suspicious
| and they're copied to netns init hook.
| 

Thanks a lot for comments Alexey! Module related calls are not needed
indeed.

		- Cyrill -