From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrill Gorcunov Subject: Re: [RFC 0/4] net namespace for PPP Date: Mon, 12 Jan 2009 00:56:03 +0300 Message-ID: <20090111215603.GB19261@localhost> References: <4967acca.0437560a.511e.0221@mx.google.com> <20090111212700.GA4008@x200.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devel@openvz.org, xemul@openvz.org To: Alexey Dobriyan Return-path: Received: from ug-out-1314.google.com ([66.249.92.168]:54814 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320AbZAKV4D (ORCPT ); Sun, 11 Jan 2009 16:56:03 -0500 Content-Disposition: inline In-Reply-To: <20090111212700.GA4008@x200.localdomain> Sender: netdev-owner@vger.kernel.org List-ID: [Alexey Dobriyan - Mon, Jan 12, 2009 at 12:27:00AM +0300] | On Fri, Jan 09, 2009 at 10:51:54PM +0300, Cyrill Gorcunov wrote: | > here is a series of RFC in attempt to implement | > net-namespaces for PPP protocol (including PPPoE | > and PPPoL2TP). | | You need assign netns to netdevice after alloc_netdev(). | This should fix much confusion and non-bugs mentioned in this thread. | | After that struct ppp shouldn't need netns pointer as it will be netns | of it's netdevice. Good point, thanks! | | current->nsproxy->net_ns while being correct in ioctl context | (it's synchronous) is easy to screwup. For example, in netfilter code netns | is taken from socket on which ioctl is done. Didn't know that, will check. | | Regardless of netns, try_module_get() calls by hand are suspicious | and they're copied to netns init hook. | Thanks a lot for comments Alexey! Module related calls are not needed indeed. - Cyrill -