netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dhollis@davehollis.com
Cc: jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: [PATCH] asix: Add support for AX88772A devices
Date: Mon, 12 Jan 2009 16:18:50 -0800 (PST)	[thread overview]
Message-ID: <20090112.161850.235337113.davem@davemloft.net> (raw)
In-Reply-To: <20090111.001704.107600670.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Sun, 11 Jan 2009 00:17:04 -0800 (PST)

> From: David Hollis <dhollis@davehollis.com>
> Date: Sat, 10 Jan 2009 10:44:25 -0500
> 
> > @@ -878,20 +885,22 @@ static struct ethtool_ops ax88772_ethtoo
> >  
> >  static int ax88772_link_reset(struct usbnet *dev)
> >  {
> > -	u16 mode;
> > -	struct ethtool_cmd ecmd;
> > +	u16 mode = AX88772_MEDIUM_DEFAULT;
> > +	u16 bmcr;
> >  
> > -	mii_check_media(&dev->mii, 1, 1);
> > -	mii_ethtool_gset(&dev->mii, &ecmd);
> > -	mode = AX88772_MEDIUM_DEFAULT;
> > +	bmcr = asix_mdio_read(dev->net, dev->mii.phy_id, MII_BMCR);
> 
> Just out of curiosity, why did you have to change this
> function to not use the generic mii_*() routines just
> to support this new device variant?

Ping?

I'm not applying this patch until you answer this question.

Thank you.

  reply	other threads:[~2009-01-13  0:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-10 15:44 [PATCH] asix: Add support for AX88772A devices David Hollis
2009-01-11  8:17 ` David Miller
2009-01-13  0:18   ` David Miller [this message]
2009-01-13  1:06     ` David Hollis
2009-01-13  1:12       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090112.161850.235337113.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dhollis@davehollis.com \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).