netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: khc@pm.waw.pl
Cc: bhutchings@solarflare.com, jarkao2@gmail.com,
	nhorman@tuxdriver.com, shemminger@vyatta.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH] net: Remove redundant NAPI functions
Date: Mon, 12 Jan 2009 16:30:21 -0800 (PST)	[thread overview]
Message-ID: <20090112.163021.132623782.davem@davemloft.net> (raw)
In-Reply-To: <m34p04bfd2.fsf@maximus.localdomain>

From: Krzysztof Halasa <khc@pm.waw.pl>
Date: Mon, 12 Jan 2009 18:31:37 +0100

> Ben Hutchings <bhutchings@solarflare.com> writes:
> 
> >> > > --- a/drivers/net/wan/ixp4xx_hss.c
> >> > > +++ b/drivers/net/wan/ixp4xx_hss.c
> >> [...]
> >> 
> >> What's the issue - does it conflict with another change to this file?
> >
> > Oh, now I see it - the device arguments hadn't already been removed.
> > Yes, I'm afraid I failed to select this driver.
> 
> It's only possible on platforms based on IXP4xx (Intel's networking
> ARM CPU).

So, as it turns out I think I need to handle this in a few stages:

1) It doesn't build upstream in Linus's tree because of the
   dev arg, so I'll fix that upstream in net-2.6

2) Then I'll rework Ben's napi_*() patch to apply on top of that.

I can do this because I haven't published my net-next-2.6 tree
yet anywhere, so I can just rebase to fix all of this up.

Thanks.

  reply	other threads:[~2009-01-13  0:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-08 20:30 [PATCH] net: Remove redundant NAPI functions Ben Hutchings
2009-01-08 20:40 ` Joe Perches
2009-01-08 20:54   ` David Miller
2009-01-09 14:58 ` Neil Horman
2009-01-10  7:06 ` David Miller
2009-01-12  7:13 ` Jarek Poplawski
2009-01-12 14:09   ` Ben Hutchings
2009-01-12 14:46     ` Ben Hutchings
2009-01-12 17:31       ` Krzysztof Halasa
2009-01-13  0:30         ` David Miller [this message]
2009-01-13  1:35           ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090112.163021.132623782.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=jarkao2@gmail.com \
    --cc=khc@pm.waw.pl \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).