From: David Miller <davem@davemloft.net>
To: gorcunov@gmail.com
Cc: paulus@samba.org, akpm@linux-foundation.org,
jchapman@katalix.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: ppp_generic - fix broken userspace
Date: Mon, 12 Jan 2009 22:12:24 -0800 (PST) [thread overview]
Message-ID: <20090112.221224.170349434.davem@davemloft.net> (raw)
In-Reply-To: <20090111114553.GA19261@localhost>
From: Cyrill Gorcunov <gorcunov@gmail.com>
Date: Sun, 11 Jan 2009 14:45:53 +0300
> David, if you pick this patch could you rename
> the subject then as Paul proposed? Or I should
> resend the patch with new title?
Done, here is the commit message I used:
net: ppp_generic - fix regressions caused by IDR conversion
The commits:
7a95d267fb62cd6b80ef73be0592bbbe1dbd5df7
("net: ppp_generic - use idr technique instead of cardmaps")
ab5024ab23b78c86a0a1425defcdde48710fe449
("net: ppp_generic - use DEFINE_IDR for static initialization")
introduced usage of IDR functionality but broke userspace side.
Before this commits it was possible to allocate new ppp interface with
specified number. Now it fails with EINVAL. Fix it by trying to
allocate interface with specified unit number and return EEXIST if
fail which allow pppd to ask us to allocate new unit number.
And fix messages on memory allocation fails - add details that it's
PPP module who is complaining.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2009-01-13 6:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 20:28 [PATCH] net: ppp_generic - fix broken userspace Cyrill Gorcunov
2009-01-10 20:31 ` Cyrill Gorcunov
2009-01-11 0:31 ` Paul Mackerras
2009-01-11 7:32 ` Cyrill Gorcunov
2009-01-11 7:35 ` David Miller
2009-01-11 10:29 ` Paul Mackerras
2009-01-11 11:45 ` Cyrill Gorcunov
2009-01-13 6:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090112.221224.170349434.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=jchapman@katalix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).