From: David Miller <davem@davemloft.net>
To: ccaputo@alt.net
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: panic with 2.6.28 while doing "ip -6 route"
Date: Tue, 13 Jan 2009 22:17:00 -0800 (PST) [thread overview]
Message-ID: <20090113.221700.221763350.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0901140610440.17915@nacho.alt.net>
From: Chris Caputo <ccaputo@alt.net>
Date: Wed, 14 Jan 2009 06:15:38 +0000 (UTC)
> On Wed, 14 Jan 2009, Herbert Xu wrote:
> > I'm surprised that it's taken nearly 3 years for this bug to
> > show itself. It even survived a move from route.c :)
> >
> > ipv6: Fix fib6_dump_table walker leak
> >
> > When a fib6 table dump is prematurely ended, we won't unlink
> > its walker from the list. This causes all sorts of grief for
> > other users of the list later.
> >
> > Reported-by: Chris Caputo <ccaputo@alt.net>
> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> >
> > diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
> > index 29c7c99..52ee1dc 100644
>
> I applied the patch, rebooted and performed about a hundred "ip -6 route |
> head" commands with the full v6 route table. The fix works great!
>
> Any chance of vectoring it for 2.6.28.x?
Sure, I'll queue it up for -stable.
next prev parent reply other threads:[~2009-01-14 6:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 2:30 panic with 2.6.28 while doing "ip -6 route" Chris Caputo
2009-01-14 5:35 ` Herbert Xu
2009-01-14 6:15 ` Chris Caputo
2009-01-14 6:17 ` David Miller [this message]
2009-01-14 6:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113.221700.221763350.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ccaputo@alt.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).