From: Stephen Hemminger <shemminger@vyatta.com>
To: Daniele Venzano <venza@brownhat.org>
Cc: netdev@vger.kernel.org, akpm@linux-foundation.org, venza@brownhat.org
Subject: Re: [PATCH] SIS900 show warning if bogus MAC address (take 2)
Date: Tue, 13 Jan 2009 11:06:21 -0800 [thread overview]
Message-ID: <20090113110621.1456a2a8@extreme> (raw)
In-Reply-To: <20090113181821.GA21342@milesteg.arr>
On Tue, 13 Jan 2009 19:18:21 +0100
Daniele Venzano <venza@brownhat.org> wrote:
> The attached patch modifies the sis900 driver when the MAC address
> read from the hardware is invalid. As suggested, the patch now
> generates a random address so that the user can go on and use
> the hardware. In any case a message is also shown to warn on the
> unexpected condition.
> This seems to happen with newer HW implementation of the sis900
> chipset, since this never came up before.
>
> Patch is against vanilla 2.6.28 (but the driver doesn't change so often,
> so it will probably apply to older/newer versions too).
>
> See bugzilla ID 10201 and 11649 and ignore the previous patch.
>
> Signed-off-by: Daniele Venzano <venza@brownhat.org>
>
> --
> Daniele Venzano
> http://www.brownhat.org
>
It would be good if this driver was converted from using dev_name (ie pci_name())
and used the standard routines which print that and more: dev_err, dev_warn, dev_dbg, etc?
next prev parent reply other threads:[~2009-01-13 19:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 18:18 [PATCH] SIS900 show warning if bogus MAC address (take 2) Daniele Venzano
2009-01-13 19:06 ` Stephen Hemminger [this message]
2009-01-13 23:44 ` Andrew Morton
2009-01-15 4:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113110621.1456a2a8@extreme \
--to=shemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=venza@brownhat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).