From: Daniele Venzano <venza@brownhat.org>
To: netdev@vger.kernel.org
Cc: akpm@linux-foundation.org, venza@brownhat.org
Subject: [PATCH] SIS900 show warning if bogus MAC address (take 2)
Date: Tue, 13 Jan 2009 19:18:21 +0100 [thread overview]
Message-ID: <20090113181821.GA21342@milesteg.arr> (raw)
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
The attached patch modifies the sis900 driver when the MAC address
read from the hardware is invalid. As suggested, the patch now
generates a random address so that the user can go on and use
the hardware. In any case a message is also shown to warn on the
unexpected condition.
This seems to happen with newer HW implementation of the sis900
chipset, since this never came up before.
Patch is against vanilla 2.6.28 (but the driver doesn't change so often,
so it will probably apply to older/newer versions too).
See bugzilla ID 10201 and 11649 and ignore the previous patch.
Signed-off-by: Daniele Venzano <venza@brownhat.org>
--
Daniele Venzano
http://www.brownhat.org
[-- Attachment #2: sis900_check_set_mac.diff --]
[-- Type: text/x-diff, Size: 645 bytes --]
--- a/drivers/net/sis900.c 2009-01-13 15:12:35.000000000 +0100
+++ b/drivers/net/sis900.c 2009-01-13 15:38:05.000000000 +0100
@@ -504,10 +504,10 @@ static int __devinit sis900_probe(struct
else
ret = sis900_get_mac_addr(pci_dev, net_dev);
- if (ret == 0) {
- printk(KERN_WARNING "%s: Cannot read MAC address.\n", dev_name);
- ret = -ENODEV;
- goto err_unmap_rx;
+ if (!ret || !is_valid_ether_addr(net_dev->dev_addr)) {
+ random_ether_addr(net_dev->dev_addr);
+ printk(KERN_WARNING "%s: Unreadable or invalid MAC address,"
+ "using random generated one\n", dev_name);
}
/* 630ET : set the mii access mode as software-mode */
next reply other threads:[~2009-01-13 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 18:18 Daniele Venzano [this message]
2009-01-13 19:06 ` [PATCH] SIS900 show warning if bogus MAC address (take 2) Stephen Hemminger
2009-01-13 23:44 ` Andrew Morton
2009-01-15 4:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113181821.GA21342@milesteg.arr \
--to=venza@brownhat.org \
--cc=akpm@linux-foundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).