* [PATCH 10/34]bnx2x: Compilation issue on IA64
@ 2009-01-14 16:43 Eilon Greenstein
2009-01-14 17:07 ` Ben Hutchings
0 siblings, 1 reply; 6+ messages in thread
From: Eilon Greenstein @ 2009-01-14 16:43 UTC (permalink / raw)
To: David Miller, netdev
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index 4993707..ba56d1c 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -1199,7 +1199,7 @@ static void bnx2x_tpa_start(struct bnx2x_fastpath *fp, u16 queue,
#ifdef BNX2X_STOP_ON_ERROR
fp->tpa_queue_used |= (1 << queue);
-#ifdef __powerpc64__
+#if (defined __powerpc64__) || (defined _ASM_IA64_TYPES_H)
DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%lx\n",
#else
DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%llx\n",
--
1.5.4.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 10/34]bnx2x: Compilation issue on IA64
2009-01-14 16:43 [PATCH 10/34]bnx2x: Compilation issue on IA64 Eilon Greenstein
@ 2009-01-14 17:07 ` Ben Hutchings
2009-01-14 17:44 ` Eilon Greenstein
0 siblings, 1 reply; 6+ messages in thread
From: Ben Hutchings @ 2009-01-14 17:07 UTC (permalink / raw)
To: Eilon Greenstein; +Cc: David Miller, netdev
On Wed, 2009-01-14 at 18:43 +0200, Eilon Greenstein wrote:
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
> ---
> drivers/net/bnx2x_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
> index 4993707..ba56d1c 100644
> --- a/drivers/net/bnx2x_main.c
> +++ b/drivers/net/bnx2x_main.c
> @@ -1199,7 +1199,7 @@ static void bnx2x_tpa_start(struct bnx2x_fastpath *fp, u16 queue,
>
> #ifdef BNX2X_STOP_ON_ERROR
> fp->tpa_queue_used |= (1 << queue);
> -#ifdef __powerpc64__
> +#if (defined __powerpc64__) || (defined _ASM_IA64_TYPES_H)
> DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%lx\n",
> #else
> DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%llx\n",
Or you could cast the value to unsigned long long and remove this
fragile #ifdef.
Maybe <linux/types.h> should define format strings like C99's PRIx64..
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 10/34]bnx2x: Compilation issue on IA64
2009-01-14 17:07 ` Ben Hutchings
@ 2009-01-14 17:44 ` Eilon Greenstein
2009-01-14 21:10 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Eilon Greenstein @ 2009-01-14 17:44 UTC (permalink / raw)
To: Ben Hutchings; +Cc: David Miller, netdev
On Wed, 2009-01-14 at 09:07 -0800, Ben Hutchings wrote:
> On Wed, 2009-01-14 at 18:43 +0200, Eilon Greenstein wrote:
> > Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
[...]
> > #ifdef BNX2X_STOP_ON_ERROR
> > fp->tpa_queue_used |= (1 << queue);
> > -#ifdef __powerpc64__
> > +#if (defined __powerpc64__) || (defined _ASM_IA64_TYPES_H)
> > DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%lx\n",
> > #else
> > DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%llx\n",
>
> Or you could cast the value to unsigned long long and remove this
> fragile #ifdef.
>
You are right - it is a better solution. The issue is that this uglier
solution is already in, and I hate to re-send this patch just for this.
Can we have this one applied and I will re visit it in net-next?
Eilon
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 10/34]bnx2x: Compilation issue on IA64
2009-01-14 17:44 ` Eilon Greenstein
@ 2009-01-14 21:10 ` David Miller
2009-01-23 8:42 ` Eilon Greenstein
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2009-01-14 21:10 UTC (permalink / raw)
To: eilong; +Cc: bhutchings, netdev
From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Wed, 14 Jan 2009 19:44:33 +0200
> On Wed, 2009-01-14 at 09:07 -0800, Ben Hutchings wrote:
> > On Wed, 2009-01-14 at 18:43 +0200, Eilon Greenstein wrote:
> > > Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
> [...]
> > > #ifdef BNX2X_STOP_ON_ERROR
> > > fp->tpa_queue_used |= (1 << queue);
> > > -#ifdef __powerpc64__
> > > +#if (defined __powerpc64__) || (defined _ASM_IA64_TYPES_H)
> > > DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%lx\n",
> > > #else
> > > DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%llx\n",
> >
> > Or you could cast the value to unsigned long long and remove this
> > fragile #ifdef.
> >
> You are right - it is a better solution. The issue is that this uglier
> solution is already in, and I hate to re-send this patch just for this.
> Can we have this one applied and I will re visit it in net-next?
There is no reason to crap up any driver with arch ifdefs, absolutely
none, for this typing issue.
The whole point is that we're trying to get all of the arch's to use
the same type for u64 in the kernel, so that these warnings can be
cleared away very easily.
Live with the warnings meanwhile until this is all sorted out.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 10/34]bnx2x: Compilation issue on IA64
2009-01-14 21:10 ` David Miller
@ 2009-01-23 8:42 ` Eilon Greenstein
2009-01-26 2:16 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Eilon Greenstein @ 2009-01-23 8:42 UTC (permalink / raw)
To: David Miller; +Cc: bhutchings@solarflare.com, netdev@vger.kernel.org
On Wed, 2009-01-14 at 13:10 -0800, David Miller wrote:
> From: "Eilon Greenstein" <eilong@broadcom.com>
> Date: Wed, 14 Jan 2009 19:44:33 +0200
>
> > On Wed, 2009-01-14 at 09:07 -0800, Ben Hutchings wrote:
> > > On Wed, 2009-01-14 at 18:43 +0200, Eilon Greenstein wrote:
> > > > Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
> > [...]
> > > > #ifdef BNX2X_STOP_ON_ERROR
> > > > fp->tpa_queue_used |= (1 << queue);
> > > > -#ifdef __powerpc64__
> > > > +#if (defined __powerpc64__) || (defined _ASM_IA64_TYPES_H)
> > > > DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%lx\n",
> > > > #else
> > > > DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%llx\n",
> > >
> > > Or you could cast the value to unsigned long long and remove this
> > > fragile #ifdef.
> > >
> > You are right - it is a better solution. The issue is that this uglier
> > solution is already in, and I hate to re-send this patch just for this.
> > Can we have this one applied and I will re visit it in net-next?
>
> There is no reason to crap up any driver with arch ifdefs, absolutely
> none, for this typing issue.
>
> The whole point is that we're trying to get all of the arch's to use
> the same type for u64 in the kernel, so that these warnings can be
> cleared away very easily.
>
> Live with the warnings meanwhile until this is all sorted out.
I can live with that, but I was wondering if this change is something
that you can consider:
-#ifdef __powerpc64__
+#ifdef _ASM_GENERIC_INT_L64_H
My problem is that in the mean time, the driver has this __powerpc64__
ifdef in it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 10/34]bnx2x: Compilation issue on IA64
2009-01-23 8:42 ` Eilon Greenstein
@ 2009-01-26 2:16 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2009-01-26 2:16 UTC (permalink / raw)
To: eilong; +Cc: bhutchings, netdev
From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Fri, 23 Jan 2009 10:42:27 +0200
> On Wed, 2009-01-14 at 13:10 -0800, David Miller wrote:
> > From: "Eilon Greenstein" <eilong@broadcom.com>
> > Date: Wed, 14 Jan 2009 19:44:33 +0200
> >
> > > On Wed, 2009-01-14 at 09:07 -0800, Ben Hutchings wrote:
> > > > On Wed, 2009-01-14 at 18:43 +0200, Eilon Greenstein wrote:
> > > > > Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
> > > [...]
> > > > > #ifdef BNX2X_STOP_ON_ERROR
> > > > > fp->tpa_queue_used |= (1 << queue);
> > > > > -#ifdef __powerpc64__
> > > > > +#if (defined __powerpc64__) || (defined _ASM_IA64_TYPES_H)
> > > > > DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%lx\n",
> > > > > #else
> > > > > DP(NETIF_MSG_RX_STATUS, "fp->tpa_queue_used = 0x%llx\n",
> > > >
> > > > Or you could cast the value to unsigned long long and remove this
> > > > fragile #ifdef.
> > > >
> > > You are right - it is a better solution. The issue is that this uglier
> > > solution is already in, and I hate to re-send this patch just for this.
> > > Can we have this one applied and I will re visit it in net-next?
> >
> > There is no reason to crap up any driver with arch ifdefs, absolutely
> > none, for this typing issue.
> >
> > The whole point is that we're trying to get all of the arch's to use
> > the same type for u64 in the kernel, so that these warnings can be
> > cleared away very easily.
> >
> > Live with the warnings meanwhile until this is all sorted out.
>
> I can live with that, but I was wondering if this change is something
> that you can consider:
> -#ifdef __powerpc64__
> +#ifdef _ASM_GENERIC_INT_L64_H
>
> My problem is that in the mean time, the driver has this __powerpc64__
> ifdef in it.
Just use %ll unconditionally and cast the argument to
long long. Then you don't need any ifdefs at all.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-01-26 2:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-14 16:43 [PATCH 10/34]bnx2x: Compilation issue on IA64 Eilon Greenstein
2009-01-14 17:07 ` Ben Hutchings
2009-01-14 17:44 ` Eilon Greenstein
2009-01-14 21:10 ` David Miller
2009-01-23 8:42 ` Eilon Greenstein
2009-01-26 2:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).