From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: herbert@gondor.apana.org.au, eilong@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH 05/34]bnx2x: Setting the GSO_TYPE with LRO
Date: Wed, 14 Jan 2009 13:12:06 -0800 (PST) [thread overview]
Message-ID: <20090114.131206.193936587.davem@davemloft.net> (raw)
In-Reply-To: <1231964842.3010.46.camel@achroite>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Wed, 14 Jan 2009 20:27:22 +0000
> On Thu, 2009-01-15 at 07:18 +1100, Herbert Xu wrote:
> > Eilon Greenstein <eilong@broadcom.com> wrote:
> > >>
> > > This is far from bullet proof solution, but IMHO it is better set then
> > > not this way, you stand a chance (depending on the output device
> > > capabilities)
> >
> > The question is simple, does your hardware guarantee that on
> > output GSO will turn the packet into exactly the same sequence
> > of packets that was seen on input, with no changes (apart from
> > what the stack would have done to them anyway, e.g., TTL update)
> > whatsoever?
> >
> > If not then you mustn't set this and also you must disable it
> > if forwarding/bridging is used.
>
> The driver just has to cooperate with dev_disable_lro() in order for the
> forwarding/bridging code to disable it. Then skb_warn_if_lro() should
> catch the case where the user mistakenly turns it back on. However,
> setting gso_type on input subverts this check.
Right, setting gso_type here is absolutely wrong.
prev parent reply other threads:[~2009-01-14 21:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 16:42 [PATCH 05/34]bnx2x: Setting the GSO_TYPE with LRO Eilon Greenstein
2009-01-14 16:57 ` Ben Hutchings
2009-01-14 17:42 ` Eilon Greenstein
2009-01-14 18:00 ` Ben Hutchings
2009-01-14 19:29 ` Eilon Greenstein
2009-01-14 20:18 ` Herbert Xu
2009-01-14 20:27 ` Ben Hutchings
2009-01-14 21:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090114.131206.193936587.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eilong@broadcom.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).