* [i4l] minor cleanups
@ 2009-01-12 12:37 Paul Bolle
2009-01-14 22:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2009-01-12 12:37 UTC (permalink / raw)
To: netdev
Minor cleanups, either made possible or obvious after commit d700555 (I4l:
convert to net_device_ops).
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Sent only to netdev@vger.kernel.org (and not also to
isdn4linux@listserv.isdn4linux.de) because an earlier ISDN patch I wrote
only got a response from this list (and this patch is NETWORKING related
anyway).
---
diff --git a/drivers/isdn/i4l/isdn_net.c b/drivers/isdn/i4l/isdn_net.c
index 7c5f970..ecc92c8 100644
--- a/drivers/isdn/i4l/isdn_net.c
+++ b/drivers/isdn/i4l/isdn_net.c
@@ -2513,7 +2513,6 @@ static const struct net_device_ops isdn_netdev_ops = {
.ndo_stop = isdn_net_close,
.ndo_do_ioctl = isdn_net_ioctl,
- .ndo_validate_addr = NULL,
.ndo_start_xmit = isdn_net_start_xmit,
.ndo_get_stats = isdn_net_get_stats,
.ndo_tx_timeout = isdn_net_tx_timeout,
@@ -2528,12 +2527,8 @@ static void _isdn_setup(struct net_device *dev)
ether_setup(dev);
- dev->flags = IFF_NOARP | IFF_POINTOPOINT;
/* Setup the generic properties */
- dev->mtu = 1500;
dev->flags = IFF_NOARP|IFF_POINTOPOINT;
- dev->type = ARPHRD_ETHER;
- dev->addr_len = ETH_ALEN;
dev->header_ops = NULL;
dev->netdev_ops = &isdn_netdev_ops;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [i4l] minor cleanups
2009-01-12 12:37 [i4l] minor cleanups Paul Bolle
@ 2009-01-14 22:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-01-14 22:42 UTC (permalink / raw)
To: pebolle; +Cc: netdev
From: Paul Bolle <pebolle@tiscali.nl>
Date: Mon, 12 Jan 2009 13:37:38 +0100
> Minor cleanups, either made possible or obvious after commit d700555 (I4l:
> convert to net_device_ops).
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-14 22:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-12 12:37 [i4l] minor cleanups Paul Bolle
2009-01-14 22:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).