From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: yanghy@cn.fujitsu.com, netdev@vger.kernel.org
Subject: Re: [PATCH]IPv6:remove duplicate check of optlen when setsockopt with IPV6_PKTINFO option
Date: Wed, 14 Jan 2009 21:45:21 -0800 (PST) [thread overview]
Message-ID: <20090114.214521.132298096.davem@davemloft.net> (raw)
In-Reply-To: <20090115053702.GA30403@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 15 Jan 2009 16:37:02 +1100
> On Thu, Jan 15, 2009 at 01:34:03PM +0800, Yang Hongyang wrote:
> >
> > Dave,there are some of the code elsewhere return EFAULT when
> > optval=NULL,I will post a patch to fix them:)
>
> I disagree. The concept of a user-space NULL pointer is different
> to that of a kernel-space NULL pointer, so the kernel should not
> be treating a user-space NULL pointer differently than any other
> pointer.
I agree with Herbert, but of course we have to adhere to cases
where APIs actually define a user NULL pointer to have a specific
meaning.
next prev parent reply other threads:[~2009-01-15 5:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 7:35 [PATCH]IPv6:remove duplicate check of optlen when setsockopt with IPV6_PKTINFO option Yang Hongyang
2009-01-14 3:47 ` Herbert Xu
2009-01-14 3:54 ` Yang Hongyang
2009-01-14 4:07 ` Wei Yongjun
2009-01-14 5:27 ` Yang Hongyang
2009-01-14 8:26 ` Shan Wei
2009-01-15 0:50 ` [PATCHv2]IPv6:remove duplicate check " Yang Hongyang
2009-01-14 4:48 ` [PATCH]IPv6:remove duplicate check of optlen " Herbert Xu
2009-01-15 5:02 ` David Miller
2009-01-15 5:04 ` Herbert Xu
2009-01-15 5:06 ` Herbert Xu
2009-01-15 5:25 ` Yang Hongyang
2009-01-15 5:43 ` David Miller
2009-01-15 5:34 ` Yang Hongyang
2009-01-15 5:37 ` Herbert Xu
2009-01-15 5:45 ` David Miller [this message]
2009-01-15 5:48 ` Herbert Xu
2009-01-15 10:07 ` Yang Hongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090114.214521.132298096.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=yanghy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).