From: David Miller <davem@davemloft.net>
To: n0-1@freewrt.org
Cc: netdev@vger.kernel.org, florian@openwrt.org, jeff@garzik.org
Subject: Re: [PATCH] korina: fix usage of driver_data
Date: Wed, 14 Jan 2009 21:47:14 -0800 (PST) [thread overview]
Message-ID: <20090114.214714.214443882.davem@davemloft.net> (raw)
In-Reply-To: <1231955241-6440-1-git-send-email-n0-1@freewrt.org>
From: Phil Sutter <n0-1@freewrt.org>
Date: Wed, 14 Jan 2009 18:47:21 +0100
> Using platform_set_drvdata() here makes no sense, since the driver_data
> field has already been filled with valuable data (i.e. the MAC address).
> Also having driver_data point to the net_device is rather pointless
> since struct korina_device contains an apropriate field for it.
>
> Signed-off-by: Phil Sutter <n0-1@freewrt.org>
Applied.
prev parent reply other threads:[~2009-01-15 5:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 15:54 [PATCH] korina: fix probing crash Florian Fainelli
2009-01-13 5:52 ` David Miller
[not found] ` <1231955241-6440-1-git-send-email-n0-1@freewrt.org>
2009-01-15 5:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090114.214714.214443882.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=florian@openwrt.org \
--cc=jeff@garzik.org \
--cc=n0-1@freewrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).