Re: [PATCH] korina: reset resource buffer size to 1536

Re: [PATCH] korina: reset resource buffer size to 1536

[Florian Fainelli]

Le Wednesday 14 January 2009 18:50:00 Phil Sutter, vous avez écrit :
> The new value is the one used in the external patch before and allows at
> least a standard MTU of 1500 to be handled correctly. Impact of this
>
> change gets visible when bigger packets are to be received, issuing:
> | ping -s 492 <IP>
>
> and bigger payload sized led to 100% packet loss.

Thanks

>
> Signed-off-by: Phil Sutter <n0-1@freewrt.org>

Acked-by: Florian Fainelli <florian@openwrt.org

-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

Re: [PATCH] korina: disable napi on close and restart

[Florian Fainelli]

Le Wednesday 14 January 2009 18:50:48 Phil Sutter, vous avez écrit :
> Without this the driver will crash when the NIC is being restarted.
>
> Signed-off-by: Phil Sutter <n0-1@freewrt.org>

Acked-by: Florian Fainelli <florian@openwrt.org>
-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

Re: [PATCH] korina: rework korina_rx() for use with napi

[Florian Fainelli]

Le Wednesday 14 January 2009 18:51:01 Phil Sutter, vous avez écrit :
> This function needs an early exit condition to function properly, or
> else caller assumes napi workload wasn't enough to handle all received
> packets and korina_rx is called again (and again and again and ...).
>
> Signed-off-by: Phil Sutter <n0-1@freewrt.org>
Acked-by: Florian Fainelli <florian@openwrt.org>

-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

Re: [PATCH] korina: do schedule napi after testing for it

[Florian Fainelli]

Le Wednesday 14 January 2009 18:51:18 Phil Sutter, vous avez écrit :
> The called netif_rx_schedule() does all the work for us:
> - it checks the return value of netif_rx_schedule_prep() and
> - if everything is ok calls __netif_rx_schedule().
> Before this change, the driver received absolutely nothing.
>
> Signed-off-by: Phil Sutter <n0-1@freewrt.org>

Acked-by: Florian Fainelli <florian@openwrt.org>

-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

Re: [PATCH] korina: do tx at the right position

[Florian Fainelli]

Le Wednesday 14 January 2009 18:51:35 Phil Sutter, vous avez écrit :
> Triggering TX before the write to the DMA status mask register leads to
> transferring packets with maximum payload no matter what the actual
> packet size is.
> While here, also trigger RX scheduling after writing the DMA status mask
> register, like it was in the original driver before it was sent
> upstream.
>
> Signed-off-by: Phil Sutter <n0-1@freewrt.org>

Acked-by: Florian Fainelli <florian@openwrt.org>
-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

Re: [PATCH] korina: fix handling tx_chain_tail

[Florian Fainelli]

Le Wednesday 14 January 2009 18:51:50 Phil Sutter, vous avez écrit :
> Originally this must have been a rewrite error when introducing
> 'chain_index'. But the original driver did not use the previous chain
> item everywhere: when altering the address tx_chain_tail points to, it
> should move forward, not backwards.

I think this was in the original driver as well.

> Also this is not an "index" but rather the penultimate element in the
> chain, so rename it accordingly.
>
> Signed-off-by: Phil Sutter <n0-1@freewrt.org>

Acked-by: Florian Fainelli <florian@openwrt.org>
-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

Re: [PATCH] korina: do not stop queue here

[Florian Fainelli]

Le Wednesday 14 January 2009 18:52:06 Phil Sutter, vous avez écrit :
> Apparently this doesn't make sense. Otherwise the queue gets disabled as
> soon as it's getting empty and can only be resurrected by a driver
> restart.
>
> Signed-off-by: Phil Sutter <n0-1@freewrt.org>

Acked-by: Florian Fainelli <florian@openwrt.org>
-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

Re: [PATCH] korina: do not use IRQF_SHARED with IRQF_DISABLED

[Florian Fainelli]

Le Wednesday 14 January 2009 18:52:20 Phil Sutter, vous avez écrit :
> As the kernel warning states: "IRQF_DISABLED is not guaranteed on shared
> IRQs". Since these IRQs' values are hardcoded and my test system doesn't
> show any shared use of IRQs at all, rather make them non-shared than
> non-disabled.
>
> Signed-off-by: Phil Sutter <n0-1@freewrt.org>

Acked-by: Florian Fainelli <florian@openwrt.org>
-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

Re: [PATCH] korina: fix handling tx_chain_tail

[Phil Sutter]

On Wed, Jan 14, 2009 at 07:00:14PM +0100, Florian Fainelli wrote:
> Le Wednesday 14 January 2009 18:51:50 Phil Sutter, vous avez écrit :
> > Originally this must have been a rewrite error when introducing
> > 'chain_index'. But the original driver did not use the previous chain
> > item everywhere: when altering the address tx_chain_tail points to, it
> > should move forward, not backwards.
> 
> I think this was in the original driver as well.

Yes, indeed.

Greetings, Phil

Re: [PATCH] korina: reset resource buffer size to 1536

[David Miller]

From: Florian Fainelli <florian@openwrt.org>
Date: Wed, 14 Jan 2009 18:57:50 +0100

> Le Wednesday 14 January 2009 18:50:00 Phil Sutter, vous avez écrit :
> > The new value is the one used in the external patch before and allows at
> > least a standard MTU of 1500 to be handled correctly. Impact of this
> >
> > change gets visible when bigger packets are to be received, issuing:
> > | ping -s 492 <IP>
> >
> > and bigger payload sized led to 100% packet loss.
> 
> Thanks
> 
> >
> > Signed-off-by: Phil Sutter <n0-1@freewrt.org>
> 
> Acked-by: Florian Fainelli <florian@openwrt.org

Applied.

Re: [PATCH] korina: disable napi on close and restart

[David Miller]

From: Florian Fainelli <florian@openwrt.org>
Date: Wed, 14 Jan 2009 18:58:25 +0100

> Le Wednesday 14 January 2009 18:50:48 Phil Sutter, vous avez écrit :
> > Without this the driver will crash when the NIC is being restarted.
> >
> > Signed-off-by: Phil Sutter <n0-1@freewrt.org>
> 
> Acked-by: Florian Fainelli <florian@openwrt.org>

Applied.

Re: [PATCH] korina: rework korina_rx() for use with napi

[David Miller]

From: Florian Fainelli <florian@openwrt.org>
Date: Wed, 14 Jan 2009 18:58:50 +0100

> Le Wednesday 14 January 2009 18:51:01 Phil Sutter, vous avez écrit :
> > This function needs an early exit condition to function properly, or
> > else caller assumes napi workload wasn't enough to handle all received
> > packets and korina_rx is called again (and again and again and ...).
> >
> > Signed-off-by: Phil Sutter <n0-1@freewrt.org>
> Acked-by: Florian Fainelli <florian@openwrt.org>

Applied.

Re: [PATCH] korina: do schedule napi after testing for it

[David Miller]

From: Florian Fainelli <florian@openwrt.org>
Date: Wed, 14 Jan 2009 18:59:04 +0100

> Le Wednesday 14 January 2009 18:51:18 Phil Sutter, vous avez écrit :
> > The called netif_rx_schedule() does all the work for us:
> > - it checks the return value of netif_rx_schedule_prep() and
> > - if everything is ok calls __netif_rx_schedule().
> > Before this change, the driver received absolutely nothing.
> >
> > Signed-off-by: Phil Sutter <n0-1@freewrt.org>
> 
> Acked-by: Florian Fainelli <florian@openwrt.org>

Applied.

Re: [PATCH] korina: do tx at the right position

[David Miller]

From: Florian Fainelli <florian@openwrt.org>
Date: Wed, 14 Jan 2009 18:59:19 +0100

> Le Wednesday 14 January 2009 18:51:35 Phil Sutter, vous avez écrit :
> > Triggering TX before the write to the DMA status mask register leads to
> > transferring packets with maximum payload no matter what the actual
> > packet size is.
> > While here, also trigger RX scheduling after writing the DMA status mask
> > register, like it was in the original driver before it was sent
> > upstream.
> >
> > Signed-off-by: Phil Sutter <n0-1@freewrt.org>
> 
> Acked-by: Florian Fainelli <florian@openwrt.org>

Applied.

Re: [PATCH] korina: fix handling tx_chain_tail

[David Miller]

From: Florian Fainelli <florian@openwrt.org>
Date: Wed, 14 Jan 2009 19:00:14 +0100

> Le Wednesday 14 January 2009 18:51:50 Phil Sutter, vous avez écrit :
> > Originally this must have been a rewrite error when introducing
> > 'chain_index'. But the original driver did not use the previous chain
> > item everywhere: when altering the address tx_chain_tail points to, it
> > should move forward, not backwards.
> 
> I think this was in the original driver as well.
> 
> > Also this is not an "index" but rather the penultimate element in the
> > chain, so rename it accordingly.
> >
> > Signed-off-by: Phil Sutter <n0-1@freewrt.org>
> 
> Acked-by: Florian Fainelli <florian@openwrt.org>

Applied.

Re: [PATCH] korina: do not stop queue here

[David Miller]

From: Florian Fainelli <florian@openwrt.org>
Date: Wed, 14 Jan 2009 19:00:38 +0100

> Le Wednesday 14 January 2009 18:52:06 Phil Sutter, vous avez écrit :
> > Apparently this doesn't make sense. Otherwise the queue gets disabled as
> > soon as it's getting empty and can only be resurrected by a driver
> > restart.
> >
> > Signed-off-by: Phil Sutter <n0-1@freewrt.org>
> 
> Acked-by: Florian Fainelli <florian@openwrt.org>

Applied.

Re: [PATCH] korina: do not use IRQF_SHARED with IRQF_DISABLED

[David Miller]

From: Florian Fainelli <florian@openwrt.org>
Date: Wed, 14 Jan 2009 19:00:50 +0100

> Le Wednesday 14 January 2009 18:52:20 Phil Sutter, vous avez écrit :
> > As the kernel warning states: "IRQF_DISABLED is not guaranteed on shared
> > IRQs". Since these IRQs' values are hardcoded and my test system doesn't
> > show any shared use of IRQs at all, rather make them non-shared than
> > non-disabled.
> >
> > Signed-off-by: Phil Sutter <n0-1@freewrt.org>
> 
> Acked-by: Florian Fainelli <florian@openwrt.org>

Also applied, thanks everyone.