From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarek Poplawski Subject: Re: [PATCH] tcp: splice as many packets as possible at once Date: Wed, 14 Jan 2009 11:45:08 +0000 Message-ID: <20090114114508.GB5848@ff.dom.local> References: <20090114085308.GB4234@ff.dom.local> <20090114.012919.117682429.davem@davemloft.net> <20090114094215.GC4234@ff.dom.local> <20090114.020637.181791518.davem@davemloft.net> <20090114104716.GE4234@ff.dom.local> <20090114112903.GB18662@gondor.apana.org.au> <20090114114059.GA5848@ff.dom.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , zbr@ioremap.net, dada1@cosmosbay.com, w@1wt.eu, ben@zeus.com, mingo@elte.hu, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jens.axboe@oracle.com To: Herbert Xu Return-path: Received: from mail-ew0-f17.google.com ([209.85.219.17]:54727 "EHLO mail-ew0-f17.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753810AbZANLpQ (ORCPT ); Wed, 14 Jan 2009 06:45:16 -0500 Content-Disposition: inline In-Reply-To: <20090114114059.GA5848@ff.dom.local> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Jan 14, 2009 at 11:40:59AM +0000, Jarek Poplawski wrote: > On Wed, Jan 14, 2009 at 10:29:03PM +1100, Herbert Xu wrote: > > On Wed, Jan 14, 2009 at 10:47:16AM +0000, Jarek Poplawski wrote: > > > > > > > > I don't think Herbert meant other ->sendpage() implementations, but I > > > > > could miss something. > > > > > > > > I think he did :-) > > > > > > I hope Herbert will make it clear. > > > > Yes I did mean the other splice paths, and in particular, the path > > to disk. I hope that's clear enough :) > > So, I think I got it right: otherwise it would be enough to make this > copy to a new page only before ->sendpage() calls e.g. in > generic_splice_sendpage(). Hmm... Actually in pipe_to_sendpage(). Jarek P.