* Re: 2.6.29-rc1-wl gives WARNING on ich8lan [not found] <20090114231546.GI1457@gamma.logic.tuwien.ac.at> @ 2009-01-15 6:25 ` Andrew Morton 2009-01-16 4:06 ` Jeff Kirsher [not found] ` <17975dc10901151417o4c5affbdrd7ef29818c8f5008@mail.gmail.com> 0 siblings, 2 replies; 4+ messages in thread From: Andrew Morton @ 2009-01-15 6:25 UTC (permalink / raw) To: Norbert Preining Cc: linux-kernel, netdev, David Graham, Bruce Allan, Jeff Kirsher On Thu, 15 Jan 2009 00:15:46 +0100 Norbert Preining <preining@logic.at> wrote: > Hi all, > > (please cc) (please cc right lists!) > 2.6.29-rc1-wl (wireless testing) gives me: > > [ 367.804080] WARNING: at drivers/net/e1000e/ich8lan.c:412 e1000_acquire_swflag_ich8lan+0x35/0xcc() > [ 367.804085] Hardware name: VGN-Z11VN_B > [ 367.804088] e1000e mutex contention. Owned by pid 3781 > [ 367.804092] Modules linked in: binfmt_misc rfcomm l2cap kvm isofs zlib_inflate fuse dm_crypt dm_mod firewire_sbp2 loop arc4 iwlagn iwlcore rfkill joydev firewire_ohci mac80211 firewire_core crc_itu_t cfg80211 btusb sony_laptop tpm_infineon video backlight > [ 367.804143] Pid: 8, comm: events/1 Not tainted 2.6.29-rc1-wl #1 > [ 367.804148] Call Trace: > [ 367.804158] [<ffffffff80236441>] warn_slowpath+0xd8/0x112 > [ 367.804169] [<ffffffff8051152f>] _spin_unlock_irqrestore+0x31/0x3d > [ 367.804178] [<ffffffff802324f9>] try_to_wake_up+0x168/0x17a > [ 367.804186] [<ffffffff8023250b>] default_wake_function+0x0/0x9 > [ 367.804196] [<ffffffff80323438>] delay_tsc+0x0/0xc8 > [ 367.804204] [<ffffffff8022c48d>] dequeue_entity+0xf/0x102 > [ 367.804211] [<ffffffff803a12a4>] e1000_acquire_swflag_ich8lan+0x35/0xcc > [ 367.804219] [<ffffffff803a5c0b>] e1000e_read_phy_reg_bm+0x39/0xbe > [ 367.804227] [<ffffffff803a5ee7>] e1000e_phy_has_link_generic+0x50/0xcc > [ 367.804234] [<ffffffff8022c48d>] dequeue_entity+0xf/0x102 > [ 367.804242] [<ffffffff803ad593>] e1000_watchdog_task+0x0/0x6ef > [ 367.804249] [<ffffffff803a4d25>] e1000e_check_for_copper_link+0x24/0x86 > [ 367.804257] [<ffffffff8023f05e>] lock_timer_base+0x26/0x4b > [ 367.804265] [<ffffffff803aa186>] e1000_has_link+0x40/0xc1 > [ 367.804272] [<ffffffff803ad5ca>] e1000_watchdog_task+0x37/0x6ef > [ 367.804280] [<ffffffff803ad593>] e1000_watchdog_task+0x0/0x6ef > [ 367.804289] [<ffffffff80245058>] run_workqueue+0x87/0x122 > [ 367.804296] [<ffffffff802451cb>] worker_thread+0xd8/0xe7 > [ 367.804304] [<ffffffff802487a8>] autoremove_wake_function+0x0/0x2e > [ 367.804311] [<ffffffff802450f3>] worker_thread+0x0/0xe7 > [ 367.804318] [<ffffffff802450f3>] worker_thread+0x0/0xe7 > [ 367.804324] [<ffffffff8024848f>] kthread+0x47/0x73 > [ 367.804332] [<ffffffff8020c6aa>] child_rip+0xa/0x20 > [ 367.804338] [<ffffffff80248448>] kthread+0x0/0x73 > [ 367.804344] [<ffffffff8020c6a0>] child_rip+0x0/0x20 > [ 367.804349] ---[ end trace 608ec83548aefe5d ]--- > > Should I be concerned? > I don't think so. It looks like it's just some developer debug code: if (!mutex_trylock(&nvm_mutex)) { WARN(1, KERN_ERR "e1000e mutex contention. Owned by process " "%s (pid %d), required by process %s (pid %d)\n", nvm_owner_name, nvm_owner_pid, current->comm, current->pid); mutex_lock(&nvm_mutex); } guys, is this actually indicative of a bug? An unexpected state? If not, I'd suggest that this code simply be removed, or downgraded into a developer-only debug thing. We don't want the kernel to be spewing scary things at people. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2.6.29-rc1-wl gives WARNING on ich8lan 2009-01-15 6:25 ` 2.6.29-rc1-wl gives WARNING on ich8lan Andrew Morton @ 2009-01-16 4:06 ` Jeff Kirsher 2009-01-16 4:13 ` Andrew Morton [not found] ` <17975dc10901151417o4c5affbdrd7ef29818c8f5008@mail.gmail.com> 1 sibling, 1 reply; 4+ messages in thread From: Jeff Kirsher @ 2009-01-16 4:06 UTC (permalink / raw) To: Andrew Morton Cc: Norbert Preining, linux-kernel, netdev, David Graham, Bruce Allan On Wed, Jan 14, 2009 at 10:25 PM, Andrew Morton <akpm@linux-foundation.org> wrote: > On Thu, 15 Jan 2009 00:15:46 +0100 Norbert Preining <preining@logic.at> wrote: > >> Hi all, >> >> (please cc) > > (please cc right lists!) > >> 2.6.29-rc1-wl (wireless testing) gives me: >> >> [ 367.804080] WARNING: at drivers/net/e1000e/ich8lan.c:412 e1000_acquire_swflag_ich8lan+0x35/0xcc() >> [ 367.804085] Hardware name: VGN-Z11VN_B >> [ 367.804088] e1000e mutex contention. Owned by pid 3781 >> [ 367.804092] Modules linked in: binfmt_misc rfcomm l2cap kvm isofs zlib_inflate fuse dm_crypt dm_mod firewire_sbp2 loop arc4 iwlagn iwlcore rfkill joydev firewire_ohci mac80211 firewire_core crc_itu_t cfg80211 btusb sony_laptop tpm_infineon video backlight >> [ 367.804143] Pid: 8, comm: events/1 Not tainted 2.6.29-rc1-wl #1 >> [ 367.804148] Call Trace: >> [ 367.804158] [<ffffffff80236441>] warn_slowpath+0xd8/0x112 >> [ 367.804169] [<ffffffff8051152f>] _spin_unlock_irqrestore+0x31/0x3d >> [ 367.804178] [<ffffffff802324f9>] try_to_wake_up+0x168/0x17a >> [ 367.804186] [<ffffffff8023250b>] default_wake_function+0x0/0x9 >> [ 367.804196] [<ffffffff80323438>] delay_tsc+0x0/0xc8 >> [ 367.804204] [<ffffffff8022c48d>] dequeue_entity+0xf/0x102 >> [ 367.804211] [<ffffffff803a12a4>] e1000_acquire_swflag_ich8lan+0x35/0xcc >> [ 367.804219] [<ffffffff803a5c0b>] e1000e_read_phy_reg_bm+0x39/0xbe >> [ 367.804227] [<ffffffff803a5ee7>] e1000e_phy_has_link_generic+0x50/0xcc >> [ 367.804234] [<ffffffff8022c48d>] dequeue_entity+0xf/0x102 >> [ 367.804242] [<ffffffff803ad593>] e1000_watchdog_task+0x0/0x6ef >> [ 367.804249] [<ffffffff803a4d25>] e1000e_check_for_copper_link+0x24/0x86 >> [ 367.804257] [<ffffffff8023f05e>] lock_timer_base+0x26/0x4b >> [ 367.804265] [<ffffffff803aa186>] e1000_has_link+0x40/0xc1 >> [ 367.804272] [<ffffffff803ad5ca>] e1000_watchdog_task+0x37/0x6ef >> [ 367.804280] [<ffffffff803ad593>] e1000_watchdog_task+0x0/0x6ef >> [ 367.804289] [<ffffffff80245058>] run_workqueue+0x87/0x122 >> [ 367.804296] [<ffffffff802451cb>] worker_thread+0xd8/0xe7 >> [ 367.804304] [<ffffffff802487a8>] autoremove_wake_function+0x0/0x2e >> [ 367.804311] [<ffffffff802450f3>] worker_thread+0x0/0xe7 >> [ 367.804318] [<ffffffff802450f3>] worker_thread+0x0/0xe7 >> [ 367.804324] [<ffffffff8024848f>] kthread+0x47/0x73 >> [ 367.804332] [<ffffffff8020c6aa>] child_rip+0xa/0x20 >> [ 367.804338] [<ffffffff80248448>] kthread+0x0/0x73 >> [ 367.804344] [<ffffffff8020c6a0>] child_rip+0x0/0x20 >> [ 367.804349] ---[ end trace 608ec83548aefe5d ]--- >> >> Should I be concerned? >> > > I don't think so. It looks like it's just some developer debug code: > > if (!mutex_trylock(&nvm_mutex)) { > WARN(1, KERN_ERR "e1000e mutex contention. Owned by process " > "%s (pid %d), required by process %s (pid %d)\n", > nvm_owner_name, nvm_owner_pid, > current->comm, current->pid); > > mutex_lock(&nvm_mutex); > } > > guys, is this actually indicative of a bug? An unexpected state? > > If not, I'd suggest that this code simply be removed, or downgraded > into a developer-only debug thing. We don't want the kernel to be > spewing scary things at people. > > -- > A message from Dave Graham <david.graham@intel.com>... The message identifies a condition that rarely occurs, and that I'd like to monitor for a few more weeks. While this WARN occurred fequently until recent 2.6.28 kernels, the messages have already helped us to tighten our code to reduce contentious access to this path, and so we now longer expect many. In fact at this time we only have one (this one) report, out of a total 1,296 WARNs shown at www.kerneloops.org for all 2.6.29-rc builds. There's been a minor improvement to the WARN message tagged as tag v2.6.29-rc1-6-geefacf3, and I'd like to collect & analyze a few reports that include that change. I'll monitor reports up at keneloops daily, and when I've got 5 or more, I can quickly move the WARN to debug-only code, so reports will soon stop. Does that sound OK? -- Cheers, Jeff ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2.6.29-rc1-wl gives WARNING on ich8lan 2009-01-16 4:06 ` Jeff Kirsher @ 2009-01-16 4:13 ` Andrew Morton 0 siblings, 0 replies; 4+ messages in thread From: Andrew Morton @ 2009-01-16 4:13 UTC (permalink / raw) To: Jeff Kirsher Cc: Norbert Preining, linux-kernel, netdev, David Graham, Bruce Allan On Thu, 15 Jan 2009 20:06:17 -0800 Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote: > On Wed, Jan 14, 2009 at 10:25 PM, Andrew Morton > <akpm@linux-foundation.org> wrote: > > On Thu, 15 Jan 2009 00:15:46 +0100 Norbert Preining <preining@logic.at> wrote: > > > >> Hi all, > >> > >> (please cc) > > > > (please cc right lists!) > > > >> 2.6.29-rc1-wl (wireless testing) gives me: > >> > >> [ 367.804080] WARNING: at drivers/net/e1000e/ich8lan.c:412 e1000_acquire_swflag_ich8lan+0x35/0xcc() > >> [ 367.804085] Hardware name: VGN-Z11VN_B > >> [ 367.804088] e1000e mutex contention. Owned by pid 3781 > >> [ 367.804092] Modules linked in: binfmt_misc rfcomm l2cap kvm isofs zlib_inflate fuse dm_crypt dm_mod firewire_sbp2 loop arc4 iwlagn iwlcore rfkill joydev firewire_ohci mac80211 firewire_core crc_itu_t cfg80211 btusb sony_laptop tpm_infineon video backlight > >> [ 367.804143] Pid: 8, comm: events/1 Not tainted 2.6.29-rc1-wl #1 > >> [ 367.804148] Call Trace: > >> [ 367.804158] [<ffffffff80236441>] warn_slowpath+0xd8/0x112 > >> [ 367.804169] [<ffffffff8051152f>] _spin_unlock_irqrestore+0x31/0x3d > >> [ 367.804178] [<ffffffff802324f9>] try_to_wake_up+0x168/0x17a > >> [ 367.804186] [<ffffffff8023250b>] default_wake_function+0x0/0x9 > >> [ 367.804196] [<ffffffff80323438>] delay_tsc+0x0/0xc8 > >> [ 367.804204] [<ffffffff8022c48d>] dequeue_entity+0xf/0x102 > >> [ 367.804211] [<ffffffff803a12a4>] e1000_acquire_swflag_ich8lan+0x35/0xcc > >> [ 367.804219] [<ffffffff803a5c0b>] e1000e_read_phy_reg_bm+0x39/0xbe > >> [ 367.804227] [<ffffffff803a5ee7>] e1000e_phy_has_link_generic+0x50/0xcc > >> [ 367.804234] [<ffffffff8022c48d>] dequeue_entity+0xf/0x102 > >> [ 367.804242] [<ffffffff803ad593>] e1000_watchdog_task+0x0/0x6ef > >> [ 367.804249] [<ffffffff803a4d25>] e1000e_check_for_copper_link+0x24/0x86 > >> [ 367.804257] [<ffffffff8023f05e>] lock_timer_base+0x26/0x4b > >> [ 367.804265] [<ffffffff803aa186>] e1000_has_link+0x40/0xc1 > >> [ 367.804272] [<ffffffff803ad5ca>] e1000_watchdog_task+0x37/0x6ef > >> [ 367.804280] [<ffffffff803ad593>] e1000_watchdog_task+0x0/0x6ef > >> [ 367.804289] [<ffffffff80245058>] run_workqueue+0x87/0x122 > >> [ 367.804296] [<ffffffff802451cb>] worker_thread+0xd8/0xe7 > >> [ 367.804304] [<ffffffff802487a8>] autoremove_wake_function+0x0/0x2e > >> [ 367.804311] [<ffffffff802450f3>] worker_thread+0x0/0xe7 > >> [ 367.804318] [<ffffffff802450f3>] worker_thread+0x0/0xe7 > >> [ 367.804324] [<ffffffff8024848f>] kthread+0x47/0x73 > >> [ 367.804332] [<ffffffff8020c6aa>] child_rip+0xa/0x20 > >> [ 367.804338] [<ffffffff80248448>] kthread+0x0/0x73 > >> [ 367.804344] [<ffffffff8020c6a0>] child_rip+0x0/0x20 > >> [ 367.804349] ---[ end trace 608ec83548aefe5d ]--- > >> > >> Should I be concerned? > >> > > > > I don't think so. It looks like it's just some developer debug code: > > > > if (!mutex_trylock(&nvm_mutex)) { > > WARN(1, KERN_ERR "e1000e mutex contention. Owned by process " > > "%s (pid %d), required by process %s (pid %d)\n", > > nvm_owner_name, nvm_owner_pid, > > current->comm, current->pid); > > > > mutex_lock(&nvm_mutex); > > } > > > > guys, is this actually indicative of a bug? An unexpected state? > > > > If not, I'd suggest that this code simply be removed, or downgraded > > into a developer-only debug thing. We don't want the kernel to be > > spewing scary things at people. > > > > -- > > > > A message from Dave Graham <david.graham@intel.com>... > > The message identifies a condition that rarely occurs, and that I'd > like to monitor for a few more weeks. While this WARN occurred > fequently until recent 2.6.28 kernels, the messages have already > helped us to tighten our code to reduce contentious access to this > path, and so we now longer expect many. In fact at this time we only > have one (this one) report, out of a total 1,296 WARNs shown at > www.kerneloops.org for all 2.6.29-rc builds. There's been a minor > improvement to the WARN message tagged as tag v2.6.29-rc1-6-geefacf3, > and I'd like to collect & analyze a few reports that include that > change. > > I'll monitor reports up at keneloops daily, and when I've got 5 or > more, I can quickly move the WARN to debug-only code, so reports will > soon stop. Does that sound OK? OK, thanks, sounds good to me. ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <17975dc10901151417o4c5affbdrd7ef29818c8f5008@mail.gmail.com>]
* Re: 2.6.29-rc1-wl gives WARNING on ich8lan [not found] ` <17975dc10901151417o4c5affbdrd7ef29818c8f5008@mail.gmail.com> @ 2009-01-18 21:39 ` Norbert Preining 0 siblings, 0 replies; 4+ messages in thread From: Norbert Preining @ 2009-01-18 21:39 UTC (permalink / raw) To: dave graham Cc: Andrew Morton, linux-kernel, netdev, Bruce Allan, Jeff Kirsher On Do, 15 Jan 2009, dave graham wrote: > I'll monitor reports up at keneloops daily, and when I've got 5 or more, I > can quickly move the WARN to debug-only code, so reports will soon If you need one more, here it is, a bit different to the previous one, at least for my eyes. [ 544.804215] ------------[ cut here ]------------ [ 544.804225] WARNING: at drivers/net/e1000e/ich8lan.c:412 e1000_acquire_swflag_ich8lan+0x35/0xcc() [ 544.804231] Hardware name: VGN-Z11VN_B [ 544.804234] e1000e mutex contention. Owned by pid 8 [ 544.804238] Modules linked in: binfmt_misc rfcomm l2cap kvm isofs zlib_inflate vfat fat fuse dm_crypt dm_mod firewire_sbp2 loop arc4 iwlagn iwlcore joydev rfkill firewire_ohci firewire_core crc_itu_t mac80211 btusb cfg80211 sony_laptop video tpm_infineon backlight [ 544.804294] Pid: 3748, comm: ifplugd Not tainted 2.6.29-rc1-wl #1 [ 544.804299] Call Trace: [ 544.804310] [<ffffffff80236441>] warn_slowpath+0xd8/0x112 [ 544.804320] [<ffffffff805105e0>] schedule_hrtimeout_range+0xa2/0xf3 [ 544.804329] [<ffffffff8024891a>] remove_wait_queue+0x12/0x41 [ 544.804337] [<ffffffff8051152f>] _spin_unlock_irqrestore+0x31/0x3d [ 544.804345] [<ffffffff80296302>] do_select+0x51d/0x53e [ 544.804353] [<ffffffff802967e6>] __pollwait+0x0/0xcd [ 544.804360] [<ffffffff802968b3>] pollwake+0x0/0x49 [ 544.804368] [<ffffffff803a5872>] e1000e_read_phy_reg_mdic+0x48/0x7a [ 544.804375] [<ffffffff803a12a4>] e1000_acquire_swflag_ich8lan+0x35/0xcc [ 544.804382] [<ffffffff803a5c0b>] e1000e_read_phy_reg_bm+0x39/0xbe [ 544.804389] [<ffffffff803a5ee7>] e1000e_phy_has_link_generic+0x50/0xcc [ 544.804396] [<ffffffff803a4d25>] e1000e_check_for_copper_link+0x24/0x86 [ 544.804405] [<ffffffff8022c437>] set_next_entity+0x34/0x56 [ 544.804412] [<ffffffff803aa186>] e1000_has_link+0x40/0xc1 [ 544.804419] [<ffffffff805114f1>] _spin_unlock_irq+0x30/0x3d [ 544.804426] [<ffffffff803a929a>] e1000_get_link+0x10/0x16 [ 544.804435] [<ffffffff8049f3f7>] ethtool_get_value+0x1f/0x42 [ 544.804442] [<ffffffff8023d507>] capable+0x3b/0x5a [ 544.804448] [<ffffffff8049f865>] dev_ethtool+0x446/0x106d [ 544.804455] [<ffffffff8022c1df>] check_preempt_wakeup+0x102/0x148 [ 544.804463] [<ffffffff8051152f>] _spin_unlock_irqrestore+0x31/0x3d [ 544.804470] [<ffffffff802324f9>] try_to_wake_up+0x168/0x17a [ 544.804488] [<ffffffff805115e6>] _spin_unlock+0x2f/0x3b [ 544.804495] [<ffffffff805103d0>] __mutex_unlock_slowpath+0x31/0x3c [ 544.804502] [<ffffffff8049b6cf>] dev_name_hash+0x19/0x5e [ 544.804509] [<ffffffff8049eae7>] dev_ioctl+0x4bf/0x5fb [ 544.804519] [<ffffffff8048ffc4>] sockfd_lookup_light+0x1a/0x51 [ 544.804528] [<ffffffff80268d83>] get_pageblock_migratetype+0x17/0x18 [ 544.804535] [<ffffffff8048ff34>] sock_ioctl+0x1ec/0x1f6 [ 544.804542] [<ffffffff80294862>] vfs_ioctl+0x21/0x6c [ 544.804548] [<ffffffff80294ce6>] do_vfs_ioctl+0x439/0x472 [ 544.804555] [<ffffffff80294d5c>] sys_ioctl+0x3d/0x5c [ 544.804561] [<ffffffff80294d21>] sys_ioctl+0x2/0x5c [ 544.804569] [<ffffffff8020b71b>] system_call_fastpath+0x16/0x1b [ 544.804574] ---[ end trace c1d34b6f12f69ad8 ]--- Best wishes Norbert ------------------------------------------------------------------------------- Dr. Norbert Preining <preining@logic.at> Vienna University of Technology Debian Developer <preining@debian.org> Debian TeX Group gpg DSA: 0x09C5B094 fp: 14DF 2E6C 0307 BE6D AD76 A9C0 D2BF 4AA3 09C5 B094 ------------------------------------------------------------------------------- Another world, another day, another dawn. --- Douglas Adams, The Hitchhikers Guide to the Galaxy ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-01-18 21:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20090114231546.GI1457@gamma.logic.tuwien.ac.at>
2009-01-15 6:25 ` 2.6.29-rc1-wl gives WARNING on ich8lan Andrew Morton
2009-01-16 4:06 ` Jeff Kirsher
2009-01-16 4:13 ` Andrew Morton
[not found] ` <17975dc10901151417o4c5affbdrd7ef29818c8f5008@mail.gmail.com>
2009-01-18 21:39 ` Norbert Preining
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).