From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PULL -tip] fixed few make headers_check warnings Date: Thu, 15 Jan 2009 15:37:17 +0100 Message-ID: <20090115143717.GA11991@uranus.ravnborg.org> References: <1231836016.3212.41.camel@jaswinder.satnam> <3f9a31f40901140129i1389f47frf32808f3a695a118@mail.gmail.com> <20090114153825.GB32082@uranus.ravnborg.org> <3f9a31f40901140759s1542e6cclae1808b796c2b1a9@mail.gmail.com> <20090114201513.GC1556@uranus.ravnborg.org> <20090115111134.GB22850@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Geert Uytterhoeven , Jaswinder Singh Rajput , Jaswinder Singh Rajput , Alan Cox , Andrew Morton , David Miller , x86 maintainers , LKML , netdev To: Ingo Molnar Return-path: Received: from pfepa.post.tele.dk ([195.41.46.235]:58219 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757314AbZAOOfh (ORCPT ); Thu, 15 Jan 2009 09:35:37 -0500 Content-Disposition: inline In-Reply-To: <20090115111134.GB22850@elte.hu> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Jan 15, 2009 at 12:11:34PM +0100, Ingo Molnar wrote: > > * Sam Ravnborg wrote: > > > So when I see "capability.h: extern's make no sense in userspace" the > > perfect approach would be that the whole file was checked. > > > > This is a much bigger task that just removing the warning. > > The problem is, you just littered the kernel with a ton of warnings and > declared that fixing them is a 'much bigger task'. > > It's not good to start projects like this, because they simply never > finish. It's _much_ better to first reach a zero baseline via minimal > fixes, then enforce 'look at the whole thing' for all _NEW_ files and > changes. > > That's how we are using checkpatch in the -tip topics, and it's working > very nicely. > > Could we please start it like that? I would have done such have I had more time to do this stuff. Real life just hit me after vacation finished and deadline approaching. I can disable the warnings around -rc7 if we think they are too noisy when we release the next kernel. Sam